Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Return 201 for message acceptance #1443

Closed
jrconlin opened this issue Nov 2, 2020 · 1 comment · Fixed by #1446 or #1447
Closed

Return 201 for message acceptance #1443

jrconlin opened this issue Nov 2, 2020 · 1 comment · Fixed by #1446 or #1447
Assignees
@jrconlin
Labels
3 Estimate - m - This is a small change, but there's some uncertainty.

Comments

@jrconlin
Copy link
Member

jrconlin commented Nov 2, 2020

Per report from user,

201 is a message accept, and 202 should only be used for delivery receipt.

We should revert #1428 and correct return behavior.

(NOTE: This will also need to be checked on autopush-rs before going live.)
@jrconlin jrconlin added 3 Estimate - m - This is a small change, but there's some uncertainty. 5 Estimate - l - Moderately complex, will require some effort but clearly defined. labels Nov 2, 2020
@jrconlin jrconlin mentioned this issue Nov 2, 2020
Open
@jrconlin jrconlin removed the 5 Estimate - l - Moderately complex, will require some effort but clearly defined. label Nov 2, 2020
jrconlin added a commit that referenced this issue Dec 2, 2020
@jrconlin
bug: return 201 for all push subscription requests.
11565a8 
Closes #1443
@jrconlin jrconlin mentioned this issue Dec 3, 2020
Merged
@jrconlin
Copy link
Member Author

jrconlin commented Dec 3, 2020

Note, the python version will not support Pushes with Receipts. The rust version will need to provide that function when it is deployed in replacement. See mozilla-services/autopush-rs#244

jrconlin added a commit that referenced this issue Dec 3, 2020
@jrconlin
bug: return 201 for all push subscription requests. (#1446)
b027907 
* bug: return 201 for all push subscription requests.
* f update cryptography dep

Closes #1443
@jrconlin jrconlin mentioned this issue Dec 3, 2020
Merged
@jrconlin jrconlin self-assigned this Dec 7, 2020
This was referenced Mar 10, 2021
Closed
Merged
@b4handjr b4handjr mentioned this issue Mar 17, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
3 Estimate - m - This is a small change, but there's some uncertainty.
Projects
None yet
Milestone
No milestone
1 participant
@jrconlin