This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: return 201 for all push subscription requests. #1446
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This version ensures that we return a status code of 201 for all subscription updates. According to https://tools.ietf.org/html/rfc8030#section-5.1 only Push Subscriptions with Receipts should ever return 202, and those are currently not supported by Autopush.
This also includes an update flagged by dependabot.
Testing
Tests included. Verification can be done by sending a push message while the recipient device is "offline".
Issue(s)
Closes #1443.