Updates. #2
Updates. #2
Conversation
Dockerfile
Outdated
| @@ -0,0 +1,18 @@ | |||
| FROM alpine:latest | |||
There was a problem hiding this comment.
You might want to use python:3-alpine (which I think currently is tied to python 3.9 and alpine 3.13. It would save you a few of the following steps.
| headers=headers, | ||
| data=base64.urlsafe_b64decode(encrypted_data[0]), | ||
| ssl=False, | ||
| ) as conn: | ||
| assert conn.status == 201 | ||
| assert conn.status == 201 or 202 |
There was a problem hiding this comment.
We might want to revisit this in the future.
There was an issue filed on Autopush a while ago noting that the RFC specification says to return 201 unless there's a receipt associated (we ignore receipt requests so basically, we shouldn't return 202). This changed the "legacy" mode where we returned 202 if a subscription was stored instead of delivered, which, in retrospect, was a terrible idea anyway.
This change is still percolating though distribution (including on the autopush-rs side).
There was a problem hiding this comment.
Sounds good. I will file an issue.
No description provided.