feat: Route notifications to FCM (Android) #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2020
jrconlin
previously approved these changes
Jul 10, 2020
Google Cloud Messaging has been deprecated in favor of FCM, and as of May 29, 2019 it no longer functions.
Also renamed the Content-Encoding header field to "encoding", which is what the rest of autopush/webpush expects.
This will make testing easier, for example with mockito.
This fixes the integration tests, because sometimes users would not have any router data in DynamoDB. Also, just to be safe, router_data uses rusoto's AttributeValue instead of serde_json::Value.
This allows us to use DynamoDbUser with any version of rusoto.
AzureMarker
force-pushed
the
feat/autoendpoint-fcm-router
branch
from
64c6f5f to
14abb92
Compare
AzureMarker
changed the base branch from
feat/autoendpoint-webpush-router
to
master
jrconlin
approved these changes
Jul 17, 2020
| let client = self.clients.get(app_id).ok_or(FcmError::InvalidAppId)?; | ||
| trace!("Sending message to FCM: {:?}", message_data); | ||
| if let Err(e) = client.send(message_data, fcm_token.to_string(), ttl).await { | ||
| return Err(self.handle_error(e)); |
There was a problem hiding this comment.
The python version was recently updated to drop UAIDs for users when we get a NOTFOUND from the bridge. We should replicate that here. It would also help trim up the router table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
Minor changes:
.gitguardian.ymlto ignore the fake OAuth credentials used during the FCM tests. config docsoperation_notes.mdabout how to set nested settings via environment variables.deny_unknown_fields)InsertOpttrait toautopush_commonto make conditionally inserting anOptioninto aHashMapeasier.Closes #162