refactor: Flatten autoendpoint server module #182
Conversation
AzureMarker
force-pushed
the
feat/autoendpoint-fcm-router
branch
from
64c6f5f to
14abb92
Compare
AzureMarker
force-pushed
the
refactor/flatten-autoendpoint
branch
from
ce9a7ce to
b444dc2
Compare
| use crate::server::extractors::notification_headers::NotificationHeaders; | ||
| use crate::server::extractors::subscription::Subscription; | ||
| use crate::extractors::notification_headers::NotificationHeaders; | ||
| use crate::extractors::subscription::Subscription; |
There was a problem hiding this comment.
optional, could probably collapse these:
use crate::extractors::{
notification_headers:::NotificationHeaders,
subscription::Subscription,
};
if you do, just need to be consistent with other, similar includes. Could save a bit of typing for any future moves like this.
There was a problem hiding this comment.
We can make rustfmt handle this automatically:
https://rust-lang.github.io/rustfmt/?version=master&search=#merge_imports
Unfortunately this currently requires nightly, until rustfmt 2.0 is released. The reason is that it is an unstable style feature because it has the potential to break code.
Alternatively, do we really want this? I agree it's more consistent and saves typing, but I've also seen the argument that it is more prone to merge conflicts.
There was a problem hiding this comment.
Yeah, it's the clippy battle. I think clippy really wanted folks to collapse when possible, probably because of tons of one line uses.
There was a problem hiding this comment.
Oh, is Clippy complaining about this? I don't see any relevant lints in https://rust-lang.github.io/rust-clippy/stable/index.html
AzureMarker
force-pushed
the
refactor/flatten-autoendpoint
branch
from
b444dc2 to
4b294f9
Compare
This PR will likely require some merge conflict resolution and rebasing, but I wanted to get it out so we fix this structure issue sooner rather than later.
Closes #157