Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #8800: clear menu highlights on use #8805

Merged

Conversation

severinrudie
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Feb 27, 2020

Codecov Report

Merging #8805 into master will increase coverage by 0.95%.
The diff coverage is 51.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8805      +/-   ##
============================================
+ Coverage     18.78%   19.73%   +0.95%     
- Complexity      502      514      +12     
============================================
  Files           331      331              
  Lines         13146    13177      +31     
  Branches       1737     1743       +6     
============================================
+ Hits           2469     2601     +132     
+ Misses        10468    10351     -117     
- Partials        209      225      +16
Impacted Files Coverage Δ Complexity Δ
...lla/fenix/components/toolbar/BrowserToolbarView.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 78.83% <100%> (+0.71%) 30 <0> (ø) ⬇️
...illa/fenix/components/toolbar/BrowserInteractor.kt 100% <100%> (ø) 7 <1> (+1) ⬆️
...lla/fenix/components/toolbar/DefaultToolbarMenu.kt 47.82% <40%> (+47.82%) 11 <8> (+11) ⬆️
...nix/components/toolbar/BrowserToolbarController.kt 64.44% <62.5%> (+2.23%) 0 <0> (ø) ⬇️
...mponents/searchengine/FenixSearchEngineProvider.kt 63.82% <0%> (-2.13%) 15% <0%> (ø)
...rg/mozilla/fenix/components/toolbar/ToolbarMenu.kt 100% <0%> (+4.34%) 0% <0%> (ø) ⬇️
.../main/java/org/mozilla/fenix/theme/ThemeManager.kt 10.81% <0%> (+10.81%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 709bf6f...16cc7f5. Read the comment docs.

@BranescuMihai BranescuMihai force-pushed the 8800-clear-menu-highlights branch 2 times, most recently from 66013d8 to 00a11da Compare March 5, 2020 08:22
@BranescuMihai BranescuMihai marked this pull request as ready for review March 5, 2020 08:28
@BranescuMihai BranescuMihai changed the title For #8800: clear menu highlights on use For #8800: clear menu highlights on use Mar 6, 2020
@BranescuMihai BranescuMihai force-pushed the 8800-clear-menu-highlights branch from 00a11da to 6f86198 Compare March 6, 2020 11:17
@BranescuMihai BranescuMihai force-pushed the 8800-clear-menu-highlights branch from 6f86198 to 15d0d0c Compare March 11, 2020 12:07
@BranescuMihai BranescuMihai force-pushed the 8800-clear-menu-highlights branch from 15d0d0c to 16cc7f5 Compare March 11, 2020 16:17
Copy link
Contributor

@mcarare mcarare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants