This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Clear browser menu highlights #8800
Labels
Comments
@vesta0 this seems important to me, are you ok with us pulling this in? And to which board? |
severinrudie
added a commit
to severinrudie/fenix
that referenced
this issue
Feb 27, 2020
severinrudie
added a commit
to severinrudie/fenix
that referenced
this issue
Feb 27, 2020
This partial implementation achieves the easier requirements described above (only clear on menu item clicked). We can build on top of it when we hear back about how to respond to menu close events. |
I don't think it would be a great experience for our users to force them to open reader view, open in app, or install a PWA simply to get the blue dot to go away. Hopefully we can get it to work on menu close, or find another event besides the user tapping on the menu item. |
Whoops! I misunderstood #7408, this one didn't need to be spun out at all. Closing as a dup of it. |
BranescuMihai
pushed a commit
to severinrudie/fenix
that referenced
this issue
Mar 2, 2020
BranescuMihai
added a commit
to severinrudie/fenix
that referenced
this issue
Mar 2, 2020
BranescuMihai
added a commit
to severinrudie/fenix
that referenced
this issue
Mar 2, 2020
BranescuMihai
pushed a commit
to severinrudie/fenix
that referenced
this issue
Mar 5, 2020
BranescuMihai
added a commit
to severinrudie/fenix
that referenced
this issue
Mar 5, 2020
BranescuMihai
added a commit
to severinrudie/fenix
that referenced
this issue
Mar 5, 2020
BranescuMihai
pushed a commit
to BranescuMihai/fenix
that referenced
this issue
Mar 5, 2020
BranescuMihai
added a commit
to BranescuMihai/fenix
that referenced
this issue
Mar 5, 2020
BranescuMihai
added a commit
to BranescuMihai/fenix
that referenced
this issue
Mar 5, 2020
BranescuMihai
pushed a commit
to severinrudie/fenix
that referenced
this issue
Mar 6, 2020
BranescuMihai
added a commit
to severinrudie/fenix
that referenced
this issue
Mar 6, 2020
BranescuMihai
added a commit
to severinrudie/fenix
that referenced
this issue
Mar 6, 2020
BranescuMihai
pushed a commit
to severinrudie/fenix
that referenced
this issue
Mar 11, 2020
BranescuMihai
added a commit
to severinrudie/fenix
that referenced
this issue
Mar 11, 2020
BranescuMihai
added a commit
to severinrudie/fenix
that referenced
this issue
Mar 11, 2020
BranescuMihai
added a commit
to severinrudie/fenix
that referenced
this issue
Mar 11, 2020
BranescuMihai
pushed a commit
that referenced
this issue
Mar 11, 2020
BranescuMihai
added a commit
that referenced
this issue
Mar 11, 2020
BranescuMihai
added a commit
that referenced
this issue
Mar 11, 2020
severinrudie
added a commit
to severinrudie/fenix
that referenced
this issue
Mar 18, 2020
severinrudie
pushed a commit
to severinrudie/fenix
that referenced
this issue
Mar 18, 2020
severinrudie
pushed a commit
to severinrudie/fenix
that referenced
this issue
Mar 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Spun out of #7408 (comment)
Why/User Benefit/User Problem
What/Requirements
For
reader view
,open in app
, andPWA
Engineering investigation notes
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: