Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Clear browser menu highlights #8800

Closed
severinrudie opened this issue Feb 26, 2020 · 4 comments
Closed

Clear browser menu highlights #8800

severinrudie opened this issue Feb 26, 2020 · 4 comments
Labels
feature request 🌟 New functionality and improvements needs:triage Issue needs triage

Comments

@severinrudie
Copy link
Contributor

severinrudie commented Feb 26, 2020

Spun out of #7408 (comment)

Why/User Benefit/User Problem

  • Un-clearable highlights (blue dots) on menu options can be annoying to users
  • We should clear these highlights after the user has seen them

What/Requirements

For reader view, open in app, and PWA

  • By default, show a highlight (already implemented)
  • After the user has opened the menu with the highlight visible, never show it again after they either:
    • Select the option
    • Or close the menu

Engineering investigation notes

  • Menu close events in the BrowserFragment do not appear to be exposed to the client. I asked about how to approach the problem here. It may require updates to AC.
  • If handling menu close events proves to be too difficult, this story would become mostly trivial from an engineering perspective if it were descoped to only clear highlights on option select. Check with @apbitner if that's acceptable.

┆Issue is synchronized with this Jira Task

@severinrudie severinrudie added the feature request 🌟 New functionality and improvements label Feb 26, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 26, 2020
@severinrudie
Copy link
Contributor Author

@vesta0 this seems important to me, are you ok with us pulling this in? And to which board?

severinrudie added a commit to severinrudie/fenix that referenced this issue Feb 27, 2020
severinrudie added a commit to severinrudie/fenix that referenced this issue Feb 27, 2020
@severinrudie
Copy link
Contributor Author

This partial implementation achieves the easier requirements described above (only clear on menu item clicked). We can build on top of it when we hear back about how to respond to menu close events.

#8805

@apbitner
Copy link

I don't think it would be a great experience for our users to force them to open reader view, open in app, or install a PWA simply to get the blue dot to go away. Hopefully we can get it to work on menu close, or find another event besides the user tapping on the menu item.

@severinrudie
Copy link
Contributor Author

Whoops! I misunderstood #7408, this one didn't need to be spun out at all. Closing as a dup of it.

BranescuMihai pushed a commit to severinrudie/fenix that referenced this issue Mar 2, 2020
BranescuMihai added a commit to severinrudie/fenix that referenced this issue Mar 2, 2020
BranescuMihai added a commit to severinrudie/fenix that referenced this issue Mar 2, 2020
BranescuMihai pushed a commit to severinrudie/fenix that referenced this issue Mar 5, 2020
BranescuMihai added a commit to severinrudie/fenix that referenced this issue Mar 5, 2020
BranescuMihai added a commit to severinrudie/fenix that referenced this issue Mar 5, 2020
BranescuMihai pushed a commit to BranescuMihai/fenix that referenced this issue Mar 5, 2020
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue Mar 5, 2020
BranescuMihai added a commit to BranescuMihai/fenix that referenced this issue Mar 5, 2020
BranescuMihai pushed a commit to severinrudie/fenix that referenced this issue Mar 6, 2020
BranescuMihai added a commit to severinrudie/fenix that referenced this issue Mar 6, 2020
BranescuMihai added a commit to severinrudie/fenix that referenced this issue Mar 6, 2020
BranescuMihai pushed a commit to severinrudie/fenix that referenced this issue Mar 11, 2020
BranescuMihai added a commit to severinrudie/fenix that referenced this issue Mar 11, 2020
BranescuMihai added a commit to severinrudie/fenix that referenced this issue Mar 11, 2020
BranescuMihai added a commit to severinrudie/fenix that referenced this issue Mar 11, 2020
@liuche liuche mentioned this issue Mar 12, 2020
32 tasks
severinrudie added a commit to severinrudie/fenix that referenced this issue Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request 🌟 New functionality and improvements needs:triage Issue needs triage
Projects
None yet
Development

No branches or pull requests

2 participants