[Bug] Sites with PWAs showing "Add to home screen" instead of "Install" on Samsung S8 and N9

[kbrosnan]

Steps to reproduce

• Using a Galaxy S8 [SM-G950U1] or Galaxy Note 9 [SM-N960U1] visit
• app.starbucks.com
• 9gag.com
• trivago.com
• pinterest.com
• twitter.com
• tap on the 3 dot menu
• look for Install option

Expected behavior

• Install option present

Actual behavior

• Add to home screen offered

Device information

• Android device: See above
• Fenix version: 4.2.1

┆Issue is synchronized with this Jira Task

[sblatz]

After discussing this in triage, it seems like what's happening is the language is wrong but it's properly installing the PWA (at least on twitter with Galaxy S9).

Let's investigate why it's intermittently showing the wrong text (sometimes we're seeing install, sometimes "add to homescreen" even on the same device & site after a refresh)

[sblatz]

@rocketsroger may have some more insights here but we can discuss during AC sprint planning.

[ekager]

I figured out what is happening here and it's a Fenix bug:
The "label" of the menu item either reads "Add to homescreen" or "Install" based on if it's a PWA.

It will only read as "Install" if this item is hightlighted.

fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt

Lines 140 to 142 in 177baf5

	if (shouldShowAddToHomescreen() && addToHomescreen.isHighlighted()) {
	lowPrioHighlightItems.add(ToolbarMenu.Item.AddToHomeScreen)
	}

But it will only be highlighted if this is true. But installPwaOpened is only true the first time a user opens the menu and sees the highlight for an "install-able" page.

fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt

Lines 264 to 268 in 177baf5

	isHighlighted = {
	val webAppUseCases = context.components.useCases.webAppUseCases
	webAppUseCases.isPinningSupported() &&
	webAppUseCases.isInstallable() &&
	!context.settings().installPwaOpened

This was a fairly recent regression added in PR #8805 for #8800

[serovar]

I don't know if it is related, but on my Pixel 2 XL feedbin.com shows "Add to home screen" instead of "Install" even if you can install it as a PWA with Chrome.

[ekager]

@serovar definitely related! The fix I just landed should be in the next Nightly, but for now if you click "Add to homescreen" for an installable PWA will still install it as a PWA. :)

[serovar]

Maybe it is not related then, since if I tap it, it adds a shortcut on my home screen, that simply opens a new tab on Fenix (while it opens properly borderless if I add it to the home screen with Chrome). I will open a new issue when I have the time, thanks for clarifying :)

[ekager]

@serovar yes if you could open a new issue with what app you're trying to install that would be great. Thanks!

[AndiAJ]

Hi @ekager , I've just checked this matter on both Debug build from Master and Fenix beta 4.3.0-beta.1 (Build #21050021) using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

✔️ Debug build from Master 4/14
• Works properly

► Video

❌ Fenix Beta - behind a feature flag
•"Add to home screen" is still displayed over the "Install" button
• It adds after the second attempt a shortcut (opened a while ago #9049 )

► Video

Considering that its fixed on Nightly and due to the fact that it's behind a feature flag which makes it unavailable on Beta 4.3.0 I'll mark this verified as fixed