-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #25810 - Unified search should give hint to user that there are more menu items available by scrolling #27895
Conversation
Talked with @Verdi about what's still needed for the unified search feature and understood that we won't need to have the selector be shown above the keyboard. |
Yes - after trying the menu positioned over the keyboard, I think it's better to show the whole thing when we can and it's ok to cover the keyboard in this case. |
Thanks @Mugurell
@Verdi ok thanks for the feedback, what is the preference on the orientation? Would a 'down' orientation perhaps more thumb friendly? |
@Verdi |
…at there are more menu items available by scrolling
This pull request has conflicts when rebasing. Could you fix it @t-p-white? 🙏 |
…int to user that there are more menu items available by scrolling (mozilla-mobile/fenix#27895) * For mozilla-mobile/fenix#25810 - Unified search should give hint to user that there are more menu items available by scrolling * For mozilla-mobile/fenix#25810: Updated AC version Co-authored-by: t-p-white <t-p-white>
Bulk of changes are in AC: See mozilla-mobile/firefox-android#181 for AC details.
The unified search 'search popup menu' should give hint to the user that there are more menu items available by scrolling. This is indicated by displaying a half menu item if the available height will not fit the full list of items.
Existing behaviour :
Original.implementation.mov
New behaviour LTR:
Screen.Recording.2023-01-03.at.15.46.15.mov
New behaviour RTL:
Screen.Recording.2023-01-03.at.15.49.03.mov
UI states:
Note: This issue is covering the direction and popup height only, another issue is in progress for positioning #27998.
Pull Request checklist
QA
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-debug
task.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
Fixes #25810