For #25810 - Unified search should give hint to user that there are m…

…ore menu items available by scrolling
mozilla-mobile · Dec 20, 2022 · 3a05dde · 3a05dde
1 parent 4e52da0
commit 3a05dde
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt b/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
@@ -361,7 +361,7 @@ class HomeFragment : Fragment() {
                 }
 
                 UnifiedSearch.searchMenuTapped.record(NoExtras())
-                searchSelectorMenu.menuController.show(anchor = it, orientation = orientation, forceOrientation = true)
+                searchSelectorMenu.menuController.show(anchor = it, orientation = orientation)
             }
         }
 

diff --git a/app/src/main/java/org/mozilla/fenix/search/toolbar/SearchSelectorToolbarAction.kt b/app/src/main/java/org/mozilla/fenix/search/toolbar/SearchSelectorToolbarAction.kt
@@ -63,7 +63,7 @@ class SearchSelectorToolbarAction(
                 }
 
                 UnifiedSearch.searchMenuTapped.record(NoExtras())
-                menu.menuController.show(anchor = it, orientation = orientation, forceOrientation = true)
+                menu.menuController.show(anchor = it, orientation = orientation)
             }
 
             val topPadding = resources.getDimensionPixelSize(R.dimen.search_engine_engine_icon_top_margin)

diff --git a/app/src/test/java/org/mozilla/fenix/search/toolbar/SearchSelectorToolbarActionTest.kt b/app/src/test/java/org/mozilla/fenix/search/toolbar/SearchSelectorToolbarActionTest.kt
@@ -87,15 +87,15 @@ class SearchSelectorToolbarActionTest {
 
         assertNotNull(UnifiedSearch.searchMenuTapped.testGetValue())
         verify {
-            menu.menuController.show(view, Orientation.DOWN, true)
+            menu.menuController.show(view, Orientation.DOWN)
         }
 
         every { settings.shouldUseBottomToolbar } returns true
         view.performClick()
 
         assertNotNull(UnifiedSearch.searchMenuTapped.testGetValue())
         verify {
-            menu.menuController.show(view, Orientation.UP, true)
+            menu.menuController.show(view, Orientation.UP)
         }
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -361,7 +361,7 @@ class HomeFragment : Fragment() { @@
                     }
                     UnifiedSearch.searchMenuTapped.record(NoExtras())
-                    searchSelectorMenu.menuController.show(anchor = it, orientation = orientation, forceOrientation = true)
+                    searchSelectorMenu.menuController.show(anchor = it, orientation = orientation)
                 }
             }
@@ Expand Down @@