Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #25810 - Unified search should give hint to user that there are more menu items available by scrolling #27895

Merged
merged 3 commits into from
Jan 9, 2023
Merged

For #25810 - Unified search should give hint to user that there are more menu items available by scrolling #27895

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8014d3f
For #25810 - Unified search should give hint to user that there are m…
Nov 17, 2022
3f1dacd
For #25810: Updated AC version
Jan 9, 2023
b123fbc
Merge branch 'main' into 25810
t-p-white Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ class HomeFragment : Fragment() {
}

UnifiedSearch.searchMenuTapped.record(NoExtras())
searchSelectorMenu.menuController.show(anchor = it, orientation = orientation, forceOrientation = true)
searchSelectorMenu.menuController.show(anchor = it, orientation = orientation)
}
}

Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/org/mozilla/fenix/search/toolbar/SearchSelectorToolbarAction.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class SearchSelectorToolbarAction(
}

UnifiedSearch.searchMenuTapped.record(NoExtras())
menu.menuController.show(anchor = it, orientation = orientation, forceOrientation = true)
menu.menuController.show(anchor = it, orientation = orientation)
}

val topPadding = resources.getDimensionPixelSize(R.dimen.search_engine_engine_icon_top_margin)
Expand Down
4 changes: 2 additions & 2 deletions app/src/test/java/org/mozilla/fenix/search/toolbar/SearchSelectorToolbarActionTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,15 @@ class SearchSelectorToolbarActionTest {

assertNotNull(UnifiedSearch.searchMenuTapped.testGetValue())
verify {
menu.menuController.show(view, Orientation.DOWN, true)
menu.menuController.show(view, Orientation.DOWN)
}

every { settings.shouldUseBottomToolbar } returns true
view.performClick()

assertNotNull(UnifiedSearch.searchMenuTapped.testGetValue())
verify {
menu.menuController.show(view, Orientation.UP, true)
menu.menuController.show(view, Orientation.UP)
}
}

Expand Down