Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4118 - Creates setting for auto closing tabs #13886

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Aug 17, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@ekager ekager force-pushed the auto-delete branch 2 times, most recently from 5ac133a to 786ce23 Compare August 17, 2020 21:43
@ekager
Copy link
Contributor Author

ekager commented Aug 17, 2020

Landing this is blocked on mozilla-mobile/android-components#7476 which is blocked on mozilla-mobile/android-components#7867

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020

Codecov Report

Merging #13886 into master will decrease coverage by 0.00%.
The diff coverage is 27.41%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #13886      +/-   ##
============================================
- Coverage     30.16%   30.15%   -0.01%     
- Complexity     1161     1167       +6     
============================================
  Files           443      444       +1     
  Lines         17847    17908      +61     
  Branches       2318     2329      +11     
============================================
+ Hits           5383     5400      +17     
- Misses        12089    12133      +44     
  Partials        375      375              
Impacted Files Coverage Δ Complexity Δ
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 5.70% <0.00%> (-0.10%) 11.00 <0.00> (ø)
...ozilla/fenix/settings/CloseTabsSettingsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ava/org/mozilla/fenix/settings/SettingsFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...main/java/org/mozilla/fenix/tabtray/TabTrayView.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../src/main/java/org/mozilla/fenix/utils/Settings.kt 66.35% <60.00%> (-0.39%) 28.00 <3.00> (+3.00) ⬇️
...ava/org/mozilla/fenix/tabtray/TabTrayController.kt 78.04% <100.00%> (+0.54%) 0.00 <0.00> (ø)
...mozilla/fenix/tabtray/TabTrayFragmentInteractor.kt 100.00% <100.00%> (ø) 14.00 <1.00> (+1.00)
...mponents/searchengine/FenixSearchEngineProvider.kt 62.16% <0.00%> (-1.81%) 13.00% <0.00%> (ø%)
...in/java/org/mozilla/fenix/settings/SupportUtils.kt 74.00% <0.00%> (+4.00%) 13.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e853a...b4a9d44. Read the comment docs.

@ekager ekager force-pushed the auto-delete branch 2 times, most recently from 8ad6766 to 404b5eb Compare August 30, 2020 16:27
@ekager ekager marked this pull request as ready for review August 31, 2020 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants