Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Move EngineSession from SessionManager to BrowserState #7867

Closed
pocmo opened this issue Jul 27, 2020 · 0 comments · Fixed by #8121
Closed

Move EngineSession from SessionManager to BrowserState #7867

pocmo opened this issue Jul 27, 2020 · 0 comments · Fixed by #8121
Assignees
@pocmo @csadilek
Labels
E13 Estimation points: 13 🌟 feature New functionality and improvements <session> Component: browser-session <state> Component: browser-state
Milestone
57.0.0 ⚛️

Comments

@pocmo
Copy link
Contributor

pocmo commented Jul 27, 2020 •
edited by data-sync-user
Loading

It is finally time to move the handling of EngineSession from SessionManager to BrowserState. A Middleware will take care of creating EngineSession instances as needed.

┆Issue is synchronized with this Jira Task
@pocmo pocmo added 🌟 feature New functionality and improvements <session> Component: browser-session <state> Component: browser-state labels Jul 27, 2020
@pocmo pocmo added the E13 Estimation points: 13 label Jul 27, 2020
@pocmo pocmo mentioned this issue Jul 27, 2020
Closed
@jonalmeida jonalmeida mentioned this issue Jul 27, 2020
Closed
@pocmo pocmo mentioned this issue Jul 28, 2020
Closed
pocmo added a commit to pocmo/android-components that referenced this issue Jul 29, 2020
@pocmo
Issue mozilla-mobile#7867: Move EngineSession from SessionManager to …
3505147 
…BrowserState.
pocmo added a commit that referenced this issue Jul 29, 2020
@pocmo
Issue #7867: Move EngineSession from SessionManager to BrowserState.
fb9f5df
@data-sync-user data-sync-user changed the title Move EngineSession from SessionManager to BrowserState FNX3-22856 ⁃ Move EngineSession from SessionManager to BrowserState Aug 5, 2020
@st3fan st3fan changed the title FNX3-22856 ⁃ Move EngineSession from SessionManager to BrowserState Move EngineSession from SessionManager to BrowserState Aug 5, 2020
pocmo added a commit that referenced this issue Aug 13, 2020
@pocmo
Issue #7867: Move EngineSession from SessionManager to BrowserState.
28e1cd4
@pocmo pocmo mentioned this issue Aug 13, 2020
Closed
@csadilek csadilek mentioned this issue Aug 14, 2020
Closed
pocmo added a commit that referenced this issue Aug 14, 2020
@pocmo @csadilek
Issue #7867: Move EngineSession from SessionManager to BrowserState.
c5e5e53 
Co-authored-by: Christian Sadilek <[email protected]>
This was referenced Aug 14, 2020
Closed
Closed
@pocmo pocmo linked a pull request Aug 14, 2020 that will close this issue
Issue #7867: Move EngineSession from SessionManager to BrowserState. #8121
Merged
4 tasks
csadilek added a commit that referenced this issue Aug 14, 2020
@pocmo @csadilek
Issue #7867: Move EngineSession from SessionManager to BrowserState.
2178f70 
Co-authored-by: Christian Sadilek <[email protected]>
csadilek added a commit that referenced this issue Aug 17, 2020
@pocmo @csadilek
Issue #7867: Move EngineSession from SessionManager to BrowserState.
e35fbb0 
Co-authored-by: Christian Sadilek <[email protected]>
@ekager ekager mentioned this issue Aug 17, 2020
Merged
4 tasks
csadilek added a commit that referenced this issue Aug 18, 2020
@pocmo @csadilek
Issue #7867: Move EngineSession from SessionManager to BrowserState.
18d16f4 
Co-authored-by: Christian Sadilek <[email protected]>
csadilek added a commit that referenced this issue Aug 18, 2020
@pocmo @csadilek
Issue #7867: Move EngineSession from SessionManager to BrowserState.
18f239d 
Co-authored-by: Christian Sadilek <[email protected]>
csadilek added a commit that referenced this issue Aug 18, 2020
@pocmo @csadilek
Issue #7867: Move EngineSession from SessionManager to BrowserState.
681319d 
Co-authored-by: Christian Sadilek <[email protected]>
csadilek added a commit that referenced this issue Aug 19, 2020
@pocmo @csadilek
Issue #7867: Move EngineSession from SessionManager to BrowserState.
96891de 
Co-authored-by: Christian Sadilek <[email protected]>
csadilek added a commit to csadilek/android-components that referenced this issue Aug 20, 2020
@pocmo @csadilek
Issue mozilla-mobile#7867: Move EngineSession from SessionManager to …
f5cf03f 
…BrowserState.

Co-authored-by: Christian Sadilek <[email protected]>
csadilek pushed a commit that referenced this issue Aug 26, 2020
@pocmo @csadilek
Issue #7867: Move EngineSession from SessionManager to BrowserState.
3054dca 
Co-authored-by: Christian Sadilek <[email protected]>

Issue #8121: Replace MigrationStore with MigrationContext and prevent usage outside of a Middleware.

* Before executing the reducer chain we now verify that we are on the store thread and throw if we are on a different thread.
* MigrationContext now provides a store property that returns the underlying Store instance. This can be used to pass it to
  other components and threads that are not part of the Middleware.
* Fixed existing Middleware implementations to use the MiddlewareContext or pass the actual Store instance around.

foo
csadilek pushed a commit that referenced this issue Aug 26, 2020
@pocmo @csadilek
Issue #7867: Move EngineSession from SessionManager to BrowserState.
9e60a62 
Co-authored-by: Christian Sadilek <[email protected]>

Issue #8121: Replace MigrationStore with MigrationContext and prevent usage outside of a Middleware.

* Before executing the reducer chain we now verify that we are on the store thread and throw if we are on a different thread.
* MigrationContext now provides a store property that returns the underlying Store instance. This can be used to pass it to
  other components and threads that are not part of the Middleware.
* Fixed existing Middleware implementations to use the MiddlewareContext or pass the actual Store instance around.
bors bot pushed a commit that referenced this issue Aug 26, 2020
@MozLando @pocmo
Merge #8121
3818667 
8121: Issue #7867: Move EngineSession from SessionManager to BrowserState. r=csadilek a=pocmo

Fenix PR: mozilla-mobile/fenix#13933
R-B PR: mozilla-mobile/reference-browser#1292



Co-authored-by: Sebastian Kaspari <[email protected]>
@bors bors bot closed this as completed in #8121 Aug 26, 2020
@pocmo pocmo added this to the 57.0.0 🤏 milestone Aug 27, 2020
@pocmo pocmo mentioned this issue Sep 16, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

@csadilek csadilek

Labels
E13 Estimation points: 13 🌟 feature New functionality and improvements <session> Component: browser-session <state> Component: browser-state
Projects
None yet
Milestone
57.0.0 ⚛️
2 participants
@pocmo @csadilek