Fixes for A-C: Move EngineSession to BrowserState #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jonalmeida
approved these changes
Aug 20, 2020
bors bot
pushed a commit
to mozilla-mobile/android-components
that referenced
this pull request
Aug 26, 2020
8121: Issue #7867: Move EngineSession from SessionManager to BrowserState. r=csadilek a=pocmo Fenix PR: mozilla-mobile/fenix#13933 R-B PR: mozilla-mobile/reference-browser#1292 Co-authored-by: Sebastian Kaspari <[email protected]>
csadilek
force-pushed
the
engine-session-refactor
branch
from
f85bded to
b222657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for breaking changes in A-C: mozilla-mobile/android-components#8121
We continue our refactoring to browser store/state. This part moves the engine session to the
BrowserStoreentirely, and no longer keeps it inSessionManager. The goal is to get rid ofSessionManagereventually.