Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Close tabs automatically after a certain amount of time passed #4118

Closed
4 tasks
ekager opened this issue Jul 17, 2019 · 6 comments
Closed
4 tasks

Close tabs automatically after a certain amount of time passed #4118

ekager opened this issue Jul 17, 2019 · 6 comments
Assignees
Labels
feature request 🌟 New functionality and improvements Feature:Tabs

Comments

@ekager
Copy link
Contributor

ekager commented Jul 17, 2019

UX specs: https://share.goabstract.com/379f7d73-3332-4949-b104-12ef523c5127?mode=design&sha=168d3adc4b4cebd5f58bcebf1e564f589a5b874a

Banner copy:

Set open tabs to close automatically that haven’t been viewed in the past day, week, or month.
DISMISS | VIEW OPTIONS

Why/User Benefit/User Problem

On mobile tabs can stack up and make it hard to find what you're looking for.

What/Requirements

Something like this that would allow users to define the amount of time before auto closing their tabs. From a recent Safari mobile version.
Image from iOS (1)

  • AC work to allow us to have a "last opened" value for tabs
  • Fenix work to build up a Setting
  • Fenix work to add this Setting to an onboarding card
  • AC/Fenix work to auto close tabs after user defined amount of time (or never)

Acceptance Criteria (how do I know when I’m done?)

Users can define how much time should pass before tabs autoclose (or never). Users should be able to change this Setting at any time. Tabs should autoclose once they have expired by the users' definition. We may want to also look into adding #2486 if we work on this feature so users can find tabs that may have closed recently that they still want easily.

┆Issue is synchronized with this Jira Task

@ghost
Copy link

ghost commented Jun 30, 2020

I keep all my tabs open until I'm finished with them. So please do not implement such a feature! Why would anyone want to close their without being done with them. After they have done all their work with the specified tabs they'll close them manually. I'm unable imagine a use case where this feature would be useful.

@ekager
Copy link
Contributor Author

ekager commented Jun 30, 2020

It would be an optional setting for users who want an easy way to manage their list of tabs.

@ghost
Copy link

ghost commented Jun 30, 2020

This isn't going to be the default setting, right (where you'd close the tabs after sometime by default)?

If it is optional then it's great as It'll provide some customization with the tab management. But the default behaviour should be to never close the open tabs.

ekager added a commit to ekager/fenix that referenced this issue Aug 17, 2020
ekager added a commit to ekager/fenix that referenced this issue Aug 17, 2020
ekager added a commit to ekager/fenix that referenced this issue Aug 17, 2020
ekager added a commit to ekager/fenix that referenced this issue Aug 17, 2020
@fschneidereit
Copy link

fschneidereit commented Aug 28, 2020

By the way, what happened to the option to close all tabs when I close the app? I think this should be part of this feature as well.

@AndiAJ
Copy link
Collaborator

AndiAJ commented Sep 2, 2020

Hi @ekager , I've just checked this feature on both Nightly 200902 and Beta 81.1.0-beta.1 using the following devices:
• Google Pixel 3a (Android 10)
• OnePlus A3 (Android 6.0.1)

✔️ The Tabs are properly being deleted as per the option the user is selecting
❓ The CFR isn't displayed (after you open more than 6 tabs or after deleting in a row 6 or more tabs )

Could you please review and advise? ☺️
I'll remove the QA needed label until further notice

@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Sep 2, 2020
@ekager
Copy link
Contributor Author

ekager commented Sep 2, 2020

Thanks for testing and sorry for any confusion!
The CFR/banner is pulled out into #14243 and is not a requirement

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request 🌟 New functionality and improvements Feature:Tabs
Projects
None yet
Development

No branches or pull requests

5 participants