Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #10071: Fixes PWA showing toolbar onPause #10306

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Apr 29, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz requested a review from ekager April 29, 2020 19:13
@sblatz sblatz force-pushed the fix-pwa-show-toolbar branch from 51721bb to d5f3bb0 Compare April 29, 2020 19:42
@codecov-io
Copy link

Codecov Report

Merging #10306 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10306   +/-   ##
=========================================
  Coverage     19.68%   19.68%           
  Complexity      600      600           
=========================================
  Files           354      354           
  Lines         14297    14296    -1     
  Branches       1916     1916           
=========================================
  Hits           2814     2814           
+ Misses        11227    11226    -1     
  Partials        256      256           
Impacted Files Coverage Δ Complexity Δ
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c95a6...d5f3bb0. Read the comment docs.

@sblatz sblatz merged commit 38e9b34 into mozilla-mobile:master Apr 29, 2020
@liuche liuche mentioned this pull request May 19, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants