Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Web Telegram PWA has a white space left when the bottom address bar disappear during scroll #10071

Closed
Blaze-Thunder opened this issue Apr 21, 2020 · 11 comments
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PWA Progressive Web App Feature:Toolbar Address bar, see also Feature:Search

Comments

@Blaze-Thunder
Copy link

Blaze-Thunder commented Apr 21, 2020

Steps to reproduce

Open Web Telegram as a PWA, scroll down. Once the address bar disappears, white space appears

Expected behavior

There shouldn't be any white space and the PWA content should be displayed normally

Actual behavior

There is a huge white space left at the place of bottom address bar

Device information

OnePlus 7 Pro, running latest Firefox nightly 200420 06:01 on Android 10

  • Android device: Android 10
  • Fenix version: 200420 06:01
    ScreenshotUNITO-UNDERSCORE!20200421-081623!

┆Issue is synchronized with this Jira Task

@Blaze-Thunder Blaze-Thunder added the 🐞 bug Crashes, Something isn't working, .. label Apr 21, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 21, 2020
@ekager ekager added the Feature:Toolbar Address bar, see also Feature:Search label Apr 21, 2020
@sblatz sblatz self-assigned this Apr 22, 2020
@sblatz
Copy link
Contributor

sblatz commented Apr 22, 2020

Seems to be some larger issues around when the nav bar is shown in PWA. It really shouldn't even be shown in this case.

@sblatz
Copy link
Contributor

sblatz commented Apr 22, 2020

Demo of problem behavior:
pwa 2020-04-22 15_01_32

@Blaze-Thunder
Copy link
Author

Here is a demo on latest nightly which I updated today via play store.
ezgif com-video-to-gif

@sblatz
Copy link
Contributor

sblatz commented Apr 23, 2020

@Blaze-Thunder Thanks for posting that! I believe that's a separate issue and I'm working with GV to get it fixed. The PWA one is one I can fix now, though 😄

@sblatz
Copy link
Contributor

sblatz commented Apr 29, 2020

@Blaze-Thunder In #8768 we will address the website issue. I'm going to use this issue to address the PWA version of the fix.

(heads up for QA, please base it off of the steps in this demo #10071 (comment))

sblatz added a commit to sblatz/fenix that referenced this issue Apr 29, 2020
sblatz added a commit to sblatz/fenix that referenced this issue Apr 29, 2020
@sblatz sblatz added the eng:qa:needed QA Needed label Apr 29, 2020
@lobontiumira
Copy link

Verified as fixed on the latest Nightly build from 5/7 using OnePlus 5T (Android 9).
I've added Web Telegram as a PWA, scrolled the homescreen, no white space displayed.
In Fenix, however, the white space is still displayed, but as Sawyer mentioned here, it will be fixed in a different issue.

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 7, 2020
@Blaze-Thunder
Copy link
Author

Will the fix be delivered late? Because I just downloaded latest Fenix nightly released on 5/7 and still I see the white space on telegram PWA.

@sblatz
Copy link
Contributor

sblatz commented May 7, 2020

@Blaze-Thunder can you send me the screenshot of your About Fenix page and a demo of this bug still happening? I'd also recommend reinstalling the Telegram PWA.

@Blaze-Thunder
Copy link
Author

@sblatz If we install it on homescreen as an app and open, there is no address bar at all.
We have to open web telegram in Fenix browser itself. This issue happens then. Attached screenshot of my build and the bug demo on the latest build.
ezgif com-video-to-gif
Screenshot_20200508-075114

@sblatz
Copy link
Contributor

sblatz commented May 8, 2020

@Blaze-Thunder As I mentioned, the PWA case is fixed, and the website version is not yet. Please follow #8768 for the web based version of this bug as this is a known issue GeckoView is working on.

@Blaze-Thunder
Copy link
Author

Got it! Thanks!

@liuche liuche mentioned this issue May 19, 2020
32 tasks
@data-sync-user data-sync-user changed the title [Bug] Web Telegram PWA has a white space left when the bottom address bar disappear during scroll FNX2-15721 ⁃ [Bug] Web Telegram PWA has a white space left when the bottom address bar disappear during scroll Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15721 ⁃ [Bug] Web Telegram PWA has a white space left when the bottom address bar disappear during scroll FNX3-13630 ⁃ [Bug] Web Telegram PWA has a white space left when the bottom address bar disappear during scroll Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13630 ⁃ [Bug] Web Telegram PWA has a white space left when the bottom address bar disappear during scroll FNX-3270 ⁃ [Bug] Web Telegram PWA has a white space left when the bottom address bar disappear during scroll Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-3270 ⁃ [Bug] Web Telegram PWA has a white space left when the bottom address bar disappear during scroll FNX2-15721 ⁃ [Bug] Web Telegram PWA has a white space left when the bottom address bar disappear during scroll Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15721 ⁃ [Bug] Web Telegram PWA has a white space left when the bottom address bar disappear during scroll [Bug] Web Telegram PWA has a white space left when the bottom address bar disappear during scroll May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PWA Progressive Web App Feature:Toolbar Address bar, see also Feature:Search
Projects
None yet
Development

No branches or pull requests

6 participants