Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] The toolbar appears on PWAs if backgrounded #10315

Closed
sv-ohorvath opened this issue Apr 30, 2020 · 7 comments
Closed

[Bug] The toolbar appears on PWAs if backgrounded #10315

sv-ohorvath opened this issue Apr 30, 2020 · 7 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:PWA Progressive Web App S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@sv-ohorvath
Copy link
Contributor

sv-ohorvath commented Apr 30, 2020

Steps to reproduce

  1. Install and open a PWA (twitter, or 9gag)
  2. Tap the task tray button.
  3. Return to the app.
    1. Expected behavior
      The toolbar should never appear on PWA while you are navigating inside its scope.
    2. Actual behavior
      The custom tab toolbar is displayed on the PWA homescreen.
      *If you choose to open the page in Fenix, from the custom tab menu, the PWA task is closed.
    3. Device information
  • Android device: Pixel 4 (Android 10), HTC Nexus 9 (Android 7.1.1)
  • Fenix version: Beta 5.0, Nightly 4/30

LE:
The toolbar appears also if a doorhanger needs to be displayed: permission to access the camera/location for example.

┆Issue is synchronized with this Jira Task

@sv-ohorvath sv-ohorvath added 🐞 bug Crashes, Something isn't working, .. Feature:PWA Progressive Web App S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels Apr 30, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 30, 2020
@sv-ohorvath sv-ohorvath removed the needs:triage Issue needs triage label Apr 30, 2020
@ekager
Copy link
Contributor

ekager commented May 1, 2020

Should be fixed by #10306 in master

@ekager ekager closed this as completed May 1, 2020
@agi90
Copy link
Contributor

agi90 commented May 15, 2020

This is still happening (screenshot from yesterdays Fenix nightly)
Screenshot_20200514-173359_Firefox Nightly

I think it happened after I reopened a PWA I hadn't used for a couple of hours.

@Archaeopteryx Archaeopteryx reopened this May 15, 2020
@agi90
Copy link
Contributor

agi90 commented May 21, 2020

I noticed that opening an instagram story triggers this. Not sure if there are more ways to trigger it.

@NotWoods NotWoods added the eng:qa:needed QA Needed label Jun 1, 2020
@NotWoods
Copy link
Contributor

NotWoods commented Jun 1, 2020

I'm not able to reproduce this anymore. Can QA check if this is still an issue?

@agi90
Copy link
Contributor

agi90 commented Jun 1, 2020

@NotWoods I can easily reproduce on the instagram PWA, open a story tap through the end and after you exit the PWA will have a toolbar.

@NotWoods NotWoods removed the eng:qa:needed QA Needed label Jun 1, 2020
@ekager
Copy link
Contributor

ekager commented Jun 1, 2020

Yeah, it now has to do with videos because on fullscreen, we are hiding the toolbar, but then when fullscreen ends, showing the toolbar again and don't treat PWAs differently right now. You can get it to show again by clicking on a link within the PWA.

@kbrosnan
Copy link
Contributor

kbrosnan commented Jun 1, 2020

issue #10452 exists to deal with the full screen problem. Closing as a dupe of #10071 which was fixed by the pr Emily mentioned.

@kbrosnan kbrosnan closed this as completed Jun 1, 2020
@data-sync-user data-sync-user changed the title [Bug] The toolbar appears on PWAs if backgrounded FNX2-15871 ⁃ [Bug] The toolbar appears on PWAs if backgrounded Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15871 ⁃ [Bug] The toolbar appears on PWAs if backgrounded FNX-3432 ⁃ [Bug] The toolbar appears on PWAs if backgrounded Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-3432 ⁃ [Bug] The toolbar appears on PWAs if backgrounded FNX2-15871 ⁃ [Bug] The toolbar appears on PWAs if backgrounded Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX2-15871 ⁃ [Bug] The toolbar appears on PWAs if backgrounded FNX3-13805 ⁃ [Bug] The toolbar appears on PWAs if backgrounded Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13805 ⁃ [Bug] The toolbar appears on PWAs if backgrounded FNX-3432 ⁃ [Bug] The toolbar appears on PWAs if backgrounded Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-3432 ⁃ [Bug] The toolbar appears on PWAs if backgrounded [Bug] The toolbar appears on PWAs if backgrounded May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:PWA Progressive Web App S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Development

No branches or pull requests

7 participants