Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped #10452

Closed
sblatz opened this issue May 6, 2020 · 7 comments
Closed

[Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped #10452

sblatz opened this issue May 6, 2020 · 7 comments
Assignees
@NotWoods
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Media Feature:PWA Progressive Web App

Comments

@sblatz
Copy link
Contributor

sblatz commented May 6, 2020 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Open a fullscreen video in PWA
  2. Put the app in the background

Expected behavior

  1. Toolbar stays hidden

Actual behavior

  1. Toolbar is force expanded and the web content is clipped improperly

demo of broken 2020-05-06 14UNITO-UNDERSCORE!29!UNITO-UNDERSCORE!03!

Discovered when working on #10433

┆Issue is synchronized with this Jira Task
@sblatz sblatz added 🐞 bug Crashes, Something isn't working, .. Feature:PWA Progressive Web App Feature:Media labels May 6, 2020
@sblatz sblatz changed the title [Bug] Exiting fullscreen video in PWA [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped May 6, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 6, 2020
@ricvelozo
Copy link

This happens after switching the open apps as well (not need to be in fullscreen video).

@sblatz
Copy link
Contributor Author

sblatz commented May 11, 2020

@ricvelozo I believe I fixed that bug a week or so ago (when I filed this one). If you use nightly you shouldn't be encountering it anymore 😄

@ekager ekager added eng:ready Ready for engineering and removed needs:triage Issue needs triage labels May 12, 2020
@kbrosnan
Copy link
Contributor

kbrosnan commented Jun 1, 2020

This also breaks in the same way if the user hits the back button or the exit fullscreen button.

@kbrosnan kbrosnan mentioned this issue Jun 1, 2020
Closed
@NotWoods NotWoods mentioned this issue Jun 2, 2020
Closed
4 tasks
@ekager
Copy link
Contributor

ekager commented Jun 11, 2020

cc @NotWoods do we have to do anything else here or will mozilla-mobile/android-components#7216 fix this without more work in Fenix?

@NotWoods
Copy link
Contributor

mozilla-mobile/android-components#7251 will fix this but will require more work in Fenix

@ekager
Copy link
Contributor

ekager commented Jun 11, 2020

Ah I see 👌 TY!

@NotWoods NotWoods self-assigned this Jun 11, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue Jun 11, 2020
@NotWoods
For mozilla-mobile#10452 - Fix PWA toolbar issue
73bef05
@kbrosnan kbrosnan mentioned this issue Jun 12, 2020
Closed
@NotWoods NotWoods added the eng:qa:needed QA Needed label Jun 19, 2020
@LaurentiuApahideanSV
Copy link

Verified as fixed on Firefox Preview Nightly 200619 (Build #2171067).

Device Used

  • Huawei MediaPad M3 (Android 7.0)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 19, 2020
@data-sync-user data-sync-user changed the title [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped FNX2-15960 ⁃ [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15960 ⁃ [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped FNX-4291 ⁃ [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-4291 ⁃ [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped FNX3-13905 ⁃ [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13905 ⁃ [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped FNX2-15960 ⁃ [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX2-15960 ⁃ [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped FNX-4291 ⁃ [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4291 ⁃ [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped [Bug] Exiting fullscreen video in PWA causes toolbar to appear and content to be clipped May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NotWoods NotWoods

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified eng:ready Ready for engineering Feature:Media Feature:PWA Progressive Web App
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kbrosnan @NotWoods @ricvelozo @sblatz @ekager @LaurentiuApahideanSV @data-sync-user