Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

List element component #8765

Closed
topotropic opened this issue Feb 26, 2020 · 6 comments
Closed

List element component #8765

topotropic opened this issue Feb 26, 2020 · 6 comments
Labels
wontfix

Comments

@topotropic
Copy link

topotropic commented Feb 26, 2020 •
edited by data-sync-user
Loading

The list element is used in

  • bookmarks,
  • history,
  • in a collection to list included sites

it should be a component with the below described spec that can be used in above listed places

image

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 26, 2020
@lime124 lime124 mentioned this issue Feb 26, 2020
Closed
@topotropic topotropic mentioned this issue Feb 26, 2020
Closed
This was referenced Mar 31, 2020
Closed
Closed
@NotWoods NotWoods self-assigned this May 14, 2020
@NotWoods
Copy link
Contributor

When items are being selected (i.e. multiple bookmarks, or creating a collection), where should the checkmark appear? In bookmarks the favicon turns into a checkmark, and in collections the checkmark appears in place of the close button.

@NotWoods
Copy link
Contributor

Some other concerns:

  • What is the color of the caption in dark mode?
  • What should the layout be for a folder in bookmarks? Currently we hide the caption and center the label.

@NotWoods NotWoods added needs:UX-feedback Needs UX Feedback and removed needs:triage Issue needs triage labels Jun 19, 2020
@AmyYLee
Copy link
Collaborator

AmyYLee commented Jul 7, 2020

@NotWoods Dark mode captions: Light grey 70 (#9F9FAD)
@topotropic for layout feedback.

@topotropic
Copy link
Author

When items are being selected (i.e. multiple bookmarks, or creating a collection), where should the checkmark appear? In bookmarks the favicon turns into a checkmark, and in collections the checkmark appears in place of the close button.

Follow the bookmark model for selection and turn the favicon into a checkmark. We'll revisit how select works for Collections as part of this issue #10163.

* What should the layout be for a folder in bookmarks? Currently we hide the caption and center the label.

Yes, that's still correct. We should follow the material guidelines here https://material.io/components/lists#specs

Looking at this again, I also realized that the shared font size here is too small and we should use 16 for the label and 12 for caption. Thanks!
image

@topotropic topotropic removed the needs:UX-feedback Needs UX Feedback label Jul 15, 2020
NotWoods added a commit to NotWoods/android-components that referenced this issue Jul 29, 2020
@NotWoods
For mozilla-mobile/fenix#8765: Add site item widget
3c44f70
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 4, 2020
@NotWoods
For mozilla-mobile/fenix#8765: Add site item widget
b204d34
@NotWoods NotWoods mentioned this issue Aug 12, 2020
Closed
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 17, 2020
@NotWoods
For mozilla-mobile/fenix#8765: Add site item widget
61b4800
NotWoods added a commit to NotWoods/android-components that referenced this issue Aug 21, 2020
@NotWoods
For mozilla-mobile/fenix#8765: Add site item widget
60d9b34
bors bot pushed a commit to mozilla-mobile/android-components that referenced this issue Aug 21, 2020
@MozLando @NotWoods
Merge #7900
0fbcf31 
7900: For mozilla-mobile/fenix#8765: Add site item widget r=gabrielluong a=NotWoods

`WidgetSiteItemView` is used to show a website inside bookmarks, history, collections, and other lists. Has the following API:
- `iconView` getter to load favicons into the view
- `setText(label, caption)` to set the text shown. If caption is null, the caption text view is hidden and the label is centered.
- `addIconOverlay` inserts other views above the `iconView`, such as a checkmark.
- `setSecondaryButton(icon, contentDescription, onClickListener)` will show an icon button with the given icon and content description. `onClickListener` is called when the button is clicked.
- `removeSecondaryButton` hides the button if it was previously shown by `setSecondaryButton`.



Co-authored-by: Tiger Oakes <[email protected]>
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 24, 2020
@NotWoods
For mozilla-mobile#8765: Use shared list widget in exceptions
c29a78e
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 24, 2020
@NotWoods
For mozilla-mobile#8765: Use shared list widget in collections
a4ffd6f
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 24, 2020
@NotWoods
For mozilla-mobile#8765: Add resource for shared list widget
6dbe429
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 24, 2020
@NotWoods
For mozilla-mobile#8765: Use shared list widget in collections
f6d216c
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 24, 2020
@NotWoods
For mozilla-mobile#8765: Use shared list widget in exceptions
17da733
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 24, 2020
@NotWoods
For mozilla-mobile#8765: Use shared list widget in exceptions
358ad1e
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 25, 2020
@NotWoods
For mozilla-mobile#8765: Add resource for shared list widget
88b8541
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 25, 2020
@NotWoods
For mozilla-mobile#8765: Use shared list widget in exceptions
34cfecf
NotWoods added a commit that referenced this issue Aug 25, 2020
@NotWoods
For #8765: Use shared list widget in exceptions (#14113)
bb3fd4e 
* For #8765: Add resource for shared list widget

* For #8765: Use shared list widget in exceptions
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 26, 2020
@NotWoods
For mozilla-mobile#8765: Use shared list widget in collections
9b1b14e
@Archaeopteryx Archaeopteryx mentioned this issue Aug 27, 2020
Closed
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 27, 2020
@NotWoods
For mozilla-mobile#8765: Used shared list widget in bookmarks
d39f37c
NotWoods added a commit to NotWoods/fenix that referenced this issue Aug 28, 2020
@NotWoods
For mozilla-mobile#8765: Used shared list widget in bookmarks
449738b
@eliserichards
Copy link

eliserichards commented Sep 16, 2020 •
edited
Loading

Approved:

Requested changes:

Merged:

Waiting:

@eliserichards eliserichards self-assigned this Sep 16, 2020
NotWoods added a commit to NotWoods/fenix that referenced this issue Sep 26, 2020
@NotWoods
For mozilla-mobile#8765: Used shared list widget in bookmarks
c0d4198
NotWoods added a commit to NotWoods/fenix that referenced this issue Sep 26, 2020
@NotWoods
For mozilla-mobile#8765: Use shared list widget in collections
be84650
bors bot pushed a commit that referenced this issue Oct 5, 2020
@MozLando @NotWoods
Merge #14316
dbcac48 
14316: For #8765: shared selection item widget and bookmarks r=eliserichards a=NotWoods

Builds ontop of #13883 and #14308.

Sets up a wrapper around WidgetSiteItemView that can handle selection, and integrates it with bookmarks.

### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [ ] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [ ] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features. In addition, it includes a screenshot of a successful [accessibility scan](https://play.google.com/store/apps/details?id=com.google.android.apps.accessibility.auditor&hl=en_US) to ensure no new defects are added to the product.

### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture


Co-authored-by: Tiger Oakes <[email protected]>
@eliserichards eliserichards mentioned this issue Oct 6, 2020
Merged
3 tasks
eliserichards pushed a commit that referenced this issue Oct 6, 2020
@NotWoods
For #8765: Use shared list widget in collections (#15733)
13f3304 
Co-authored-by: Tiger Oakes <[email protected]>
NotWoods added a commit to NotWoods/fenix that referenced this issue Oct 14, 2020
@NotWoods
For mozilla-mobile#8765: Used shared list widget in bookmarks
338aca8
NotWoods added a commit to NotWoods/fenix that referenced this issue Oct 17, 2020
@NotWoods
For mozilla-mobile#8765: Used shared list widget in bookmarks
3d3a3b7
@stale
Copy link

stale bot commented Jun 15, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 15, 2021
@stale stale bot closed this as completed Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@topotropic @NotWoods @AmyYLee @eliserichards