Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

LibrarySiteItemView unnecessarily nests ConstraintLayouts #13408

Closed
person808 opened this issue Aug 7, 2020 · 2 comments
Closed

LibrarySiteItemView unnecessarily nests ConstraintLayouts #13408

person808 opened this issue Aug 7, 2020 · 2 comments
Labels
eng:health Improve code health good first issue Good for newcomers wontfix

Comments

@person808
Copy link
Contributor

person808 commented Aug 7, 2020

LibrarySiteItemView extends ConstraintLayout and inflates library_site_item.xml inside of it. However, library_site_item.xml contains a ConstraintLayout in its top level, resulting in an unnecessary ConstraintLayout being inflated. This looks like a good candidate for using a <merge> tag in the xml.

┆Issue is synchronized with this Jira Task

@person808 person808 added good first issue Good for newcomers eng:health Improve code health labels Aug 7, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 7, 2020
@person808 person808 removed the needs:triage Issue needs triage label Aug 7, 2020
@person808 person808 changed the title LibrarySiteItemView unnecessarilly nests ConstraintLayouts LibrarySiteItemView unnecessarily nests ConstraintLayouts Aug 7, 2020
@data-sync-user data-sync-user changed the title LibrarySiteItemView unnecessarily nests ConstraintLayouts FNX3-23083 ⁃ LibrarySiteItemView unnecessarily nests ConstraintLayouts Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-23083 ⁃ LibrarySiteItemView unnecessarily nests ConstraintLayouts FNX-14589 ⁃ LibrarySiteItemView unnecessarily nests ConstraintLayouts Aug 11, 2020
@NotWoods
Copy link
Contributor

Did not realize this creates two layouts, oops. We're planning to replace library_site_item.xml with a shared UI component (#8765) so the better solution may be to just delegate to that instead.

@stale
Copy link

stale bot commented Feb 8, 2021

See: #17373 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 8, 2021
@stale stale bot closed this as completed Feb 15, 2021
@data-sync-user data-sync-user changed the title FNX-14589 ⁃ LibrarySiteItemView unnecessarily nests ConstraintLayouts LibrarySiteItemView unnecessarily nests ConstraintLayouts May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:health Improve code health good first issue Good for newcomers wontfix
Projects
None yet
Development

No branches or pull requests

2 participants