Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For mozilla-mobile/fenix#8765: Add site item widget #7900

Merged
merged 2 commits into from
Aug 21, 2020

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Jul 29, 2020

WidgetSiteItemView is used to show a website inside bookmarks, history, collections, and other lists. Has the following API:

  • iconView getter to load favicons into the view
  • setText(label, caption) to set the text shown. If caption is null, the caption text view is hidden and the label is centered.
  • addIconOverlay inserts other views above the iconView, such as a checkmark.
  • setSecondaryButton(icon, contentDescription, onClickListener) will show an icon button with the given icon and content description. onClickListener is called when the button is clicked.
  • removeSecondaryButton hides the button if it was previously shown by setSecondaryButton.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@NotWoods NotWoods requested a review from gabrielluong July 29, 2020 00:57
@NotWoods NotWoods force-pushed the 8795_site-list-item branch 2 times, most recently from e0c03a4 to f940eab Compare July 29, 2020 17:58
@gabrielluong gabrielluong self-assigned this Aug 3, 2020
@NotWoods NotWoods force-pushed the 8795_site-list-item branch from f940eab to d1cb6fe Compare August 4, 2020 22:57
@NotWoods NotWoods force-pushed the 8795_site-list-item branch from d1cb6fe to 381f87e Compare August 17, 2020 16:28
@NotWoods NotWoods force-pushed the 8795_site-list-item branch from 381f87e to 6fc3914 Compare August 21, 2020 20:46
@NotWoods
Copy link
Contributor Author

bors r=gabrielluong

@bors
Copy link

bors bot commented Aug 21, 2020

Build succeeded:

@bors bors bot merged commit 0fbcf31 into mozilla-mobile:master Aug 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants