This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
For #7468 - Don't set notification style on Huawei devices on lollipop #7514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotWoods
approved these changes
Jun 25, 2020
| @@ -21,6 +22,7 @@ import mozilla.components.feature.media.ext.nonPrivateIcon | |||
| import mozilla.components.feature.media.ext.nonPrivateUrl | |||
| import mozilla.components.feature.media.service.AbstractMediaService | |||
| import mozilla.components.support.base.ids.SharedIdsHelper | |||
| import java.util.* | |||
There was a problem hiding this comment.
Looks like this got included by accident
There was a problem hiding this comment.
the star import is an accident but it needs the locale package 😢
…ces on lollipop
|
bors r=NotWoods |
bors bot
pushed a commit
that referenced
this pull request
Jun 25, 2020
7502: Closes #7474: API for counting recently used PWAs r=NotWoods a=grigoryk Skipped adding tests for the shortcut manager class, as they'd be even more useless than the manifest storage tests. Currently, we're not actually exercising a storage layer, which android docs seem to advise against due to a likely sqlite version mismatch (unless you run your tests on-device, which is rather slow). 7514: For #7468 - Don't set notification style on Huawei devices on lollipop r=NotWoods a=ekager Co-authored-by: Grisha Kruglov <[email protected]> Co-authored-by: ekager <[email protected]>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jun 25, 2020
7499: Close #7495: Wait for firstContentfulPaint in BrowserThumbnail r=gabrielluong a=jonalmeida 7514: For #7468 - Don't set notification style on Huawei devices on lollipop r=NotWoods a=ekager Co-authored-by: Jonathan Almeida <[email protected]> Co-authored-by: ekager <[email protected]>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Jun 25, 2020
7514: For #7468 - Don't set notification style on Huawei devices on lollipop r=NotWoods a=ekager Co-authored-by: ekager <[email protected]>
|
Build failed: |
ekager
added
🛬 needs landing
|
bors retry |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge