Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #7474: API for counting recently used PWAs #7502

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

grigoryk
Copy link
Contributor

@grigoryk grigoryk commented Jun 25, 2020

Skipped adding tests for the shortcut manager class, as they'd be even more useless than the manifest storage tests. Currently, we're not actually exercising a storage layer, which android docs seem to advise against due to a likely sqlite version mismatch (unless you run your tests on-device, which is rather slow).


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

We're not using this API in any of our consumers, and it doesn't seem like "disabling shortcut"
is actually a good proxy for "uninstalling".
@grigoryk grigoryk requested a review from NotWoods June 25, 2020 01:28
…ger API

This also includes minor clean-up (typos, renaming a few method signature variables).
@grigoryk
Copy link
Contributor Author

bors r=NotWoods

bors bot pushed a commit that referenced this pull request Jun 25, 2020
7502: Closes #7474: API for counting recently used PWAs r=NotWoods a=grigoryk

Skipped adding tests for the shortcut manager class, as they'd be even more useless than the manifest storage tests. Currently, we're not actually exercising a storage layer, which android docs seem to advise against due to a likely sqlite version mismatch (unless you run your tests on-device, which is rather slow).



7514: For #7468 - Don't set notification style on Huawei devices on lollipop r=NotWoods a=ekager



Co-authored-by: Grisha Kruglov <[email protected]>
Co-authored-by: ekager <[email protected]>
@bors
Copy link

bors bot commented Jun 25, 2020

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 25, 2020
7502: Closes #7474: API for counting recently used PWAs r=NotWoods a=grigoryk

Skipped adding tests for the shortcut manager class, as they'd be even more useless than the manifest storage tests. Currently, we're not actually exercising a storage layer, which android docs seem to advise against due to a likely sqlite version mismatch (unless you run your tests on-device, which is rather slow).



Co-authored-by: Grisha Kruglov <[email protected]>
@bors
Copy link

bors bot commented Jun 25, 2020

Build failed:

@grigoryk
Copy link
Contributor Author

on the latest bors attempt:

  • browser-engine-system is a network failure;
  • ui-browser and ui-glean are the same error (can't load glean) (and unrelated to this PR):
java.lang.ExceptionInInitializerError

     FATAL EXCEPTION: GleanAPIPool
Process: org.mozilla.samples.browser, PID: 6204
java.lang.ExceptionInInitializerError
	at mozilla.telemetry.glean.GleanInternalAPI$initialize$1.invokeSuspend(Glean.kt:151)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:422)
	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:152)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:265)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
	at java.lang.Thread.run(Thread.java:818)
Caused by: java.lang.IllegalStateException: Glean functionality not available
	at mozilla.telemetry.glean.rust.LibGleanFFI$Companion$INSTANCE$1.invoke(LibGleanFFI.kt:79)
	at mozilla.telemetry.glean.rust.LibGleanFFI$Companion$INSTANCE$1.invoke(LibGleanFFI.kt:67)
	at java.lang.reflect.Proxy.invoke(Proxy.java:397)
	at $Proxy2.glean_new_ping_type(Unknown Source)
	at mozilla.telemetry.glean.private.PingType.<init>(PingType.kt:54)
	at mozilla.telemetry.glean.GleanMetrics.Pings.<clinit>(Pings.kt:52)
	... 10 more
Caused by: java.lang.UnsatisfiedLinkError: Unable to load library 'glean_ffi':
dlopen failed: cannot locate symbol "stderr" referenced by "libglean_ffi.so"...
dlopen failed: cannot locate symbol "stderr" referenced by "libglean_ffi.so"...
dlopen failed: cannot locate symbol "stderr" referenced by "libglean_ffi.so"...
Native library (android-x86/libglean_ffi.so) not found in resource path (.)
	at com.sun.jna.NativeLibrary.loadLibrary(NativeLibrary.java:302)
	at com.sun.jna.NativeLibrary.getInstance(NativeLibrary.java:455)
	at com.sun.jna.Library$Handler.<init>(Library.java:179)
	at com.sun.jna.Native.load(Native.java:596)
	at com.sun.jna.Native.load(Native.java:570)
	at mozilla.telemetry.glean.rust.LibGleanFFI$Companion.<clinit>(LibGleanFFI.kt:71)
	at mozilla.telemetry.glean.rust.LibGleanFFI.<clinit>(LibGleanFFI.kt)
	... 12 more
	Suppressed: java.lang.UnsatisfiedLinkError: dlopen failed: cannot locate symbol "stderr" referenced by "libglean_ffi.so"...
		at com.sun.jna.Native.open(Native Method)
		at com.sun.jna.NativeLibrary.loadLibrary(NativeLibrary.java:191)
		... 18 more
	Suppressed: java.lang.UnsatisfiedLinkError: dlopen failed: cannot locate symbol "stderr" referenced by "libglean_ffi.so"...
		at com.sun.jna.Native.open(Native Method)
		at com.sun.jna.NativeLibrary.loadLibrary(NativeLibrary.java:204)
		... 18 more
	Suppressed: java.lang.UnsatisfiedLinkError: dlopen failed: cannot locate symbol "stderr" referenced by "libglean_ffi.so"...
		at java.lang.Runtime.loadLibrary(Runtime.java:371)
		at java.lang.System.loadLibrary(System.java:989)
		at com.sun.jna.NativeLibrary.loadLibrary(NativeLibrary.java:218)
		... 18 more
	Suppressed: java.io.IOException: Native library (android-x86/libglean_ffi.so) not found in resource path (.)
		at com.sun.jna.Native.extractFromResourcePath(Native.java:1089)
		at com.sun.jna.NativeLibrary.loadLibrary(NativeLibrary.java:276)
		... 18 more

@grigoryk
Copy link
Contributor Author

bors retry

@bors
Copy link

bors bot commented Jun 25, 2020

Build succeeded:

@bors bors bot merged commit 84eff97 into mozilla-mobile:master Jun 25, 2020
@grigoryk grigoryk deleted the issue7474PwaCount branch June 25, 2020 23:35
@grigoryk grigoryk added this to the 48.0.0 milestone Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants