-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closes #11909: Metrics for recording number of recently used PWAs #11982
Closes #11909: Metrics for recording number of recently used PWAs #11982
Conversation
Will fill-out a data review once I confirm this is all good and working as expected. |
a0995b0
to
e8b487d
Compare
Confirmed that this does work, but needs mozilla-mobile/android-components#7519 to land first. |
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
We want to know if our users are actually using PWAs, and if so how many.
These counts are crucial in understand impact of the PWA functionality, and helpful in understanding other browser usage in context of how this feature is used.
We are also working on event telemetry for PWAs for more detailed usage information, but it won't be a substitute for this simple high-level metric.
No.
Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
This collection is documented in the metrics.md document
expires: "2020-12-01"
All channels/locales.
Standard Glean opt-out.
Through a re-dash dashboard.
Within Fenix/A-C teams.
No. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, documented in metrics.md
- Is there a control mechanism that allows the user to turn the data collection on and off?
controlled by Fenix data controls
- If the request is for permanent data collection, is there someone who will monitor the data over time?
Expiry 12/1/2020
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2, usage of PWA feature
- Is the data collection request for default-on or default-off?
default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No, usage counter
- Is the data collection covered by the existing Firefox privacy notice?
yes
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
No, expiry will kick in
- Does the data collection use a third-party collection tool? If yes, escalate to legal.
No
@@ -523,6 +527,23 @@ open class HomeActivity : LocaleAwareAppCompatActivity() { | |||
this.visualCompletenessQueue = visualCompletenessQueue | |||
} | |||
|
|||
private fun captureSnapshotTelemetryMetrics() = CoroutineScope(Dispatchers.IO).launch { | |||
// PWA | |||
val recentlyUsedPwaCount = components.core.webAppShortcutManager.recentlyUsedWebAppsCount( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what a convenient call, is it just for telemetry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup.
e8b487d
to
9b198e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have a few nits 😄
9b198e1
to
f008d75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🥇
d218025
to
4ecc9d3
Compare
4ecc9d3
to
c4b119a
Compare
Requires mozilla-mobile/android-components#7502 and mozilla-mobile/android-components#7519
We can't count exact installs (Android doesn't inform us about their deletions), so instead we look at number of "recently used" (within last 30 days) as a proxy value.
Pull Request checklist
After merge
To download an APK when reviewing a PR: