Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planning request adapter, port to ROS 2 #62

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Planning request adapter, port to ROS 2 #62

merged 3 commits into from
Apr 9, 2019

Conversation

vmayoral
Copy link
Contributor

No description provided.

@vmayoral vmayoral changed the title Planning request adapter Planning request adapter, port to ROS 2 Mar 31, 2019
@vmayoral
Copy link
Contributor Author

vmayoral commented Apr 8, 2019

Current CI won't do as discussed at moveit/moveit_ci#56. There're several limitations in the Docker image which won't allow moveit2 packages to compile. In addition we're still facing problems with the unit tests that need further work (and assistance) AcutronicRobotics#13.

Until we resolve this issues, I'd advice to consider this PR again since it passes a fixed moveit_ci CI.

This was referenced Apr 8, 2019
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
mlautman
mlautman approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@mlautman mlautman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. I still believe that we need to get CI passing before we merge too much work. Part of verifying that things like this are working is getting the CI into a working state. If there are issues with the CI, let's solve them first

@mlautman
Copy link
Contributor

mlautman commented Apr 9, 2019

this PR is really straightforward so I am ok with merging and revisiting once we have moveit_core building

@mlautman mlautman merged commit 7b05388 into moveit:master Apr 9, 2019
@vmayoral vmayoral deleted the planning-request-adapter branch April 12, 2019 15:39
JafarAbdi pushed a commit to JafarAbdi/moveit2 that referenced this pull request Oct 28, 2019
@LanderU
Merge pull request moveit#62 from AcutronicRobotics/updaterepos
e7c2279 
Update moveit2.repos
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
@davetcoleman
Rename various pages, reword intros (moveit#62)
a98c196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlautman mlautman mlautman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vmayoral @mlautman