Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic with enforcing constrained planning state space #1589

Conversation

stephanie-eng
Copy link
Contributor

Description

Fixes #1552, change to logic when enforcing constrained planning state space in the mixed constraint case.

When running the constrained planning tutorial with:
ros2 launch moveit2_tutorials ompl_constrained_planning.launch.py

You should see the following log for the last example (required debug log level):
[moveit.ompl_planning.planning_context_manager]: planning_context_manager: Using OMPL's constrained state space for planning.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 51.11% // Head: 51.10% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (5572a76) compared to base (71e6d90).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
- Coverage   51.11%   51.10%   -0.00%     
==========================================
  Files         380      380              
  Lines       31796    31796              
==========================================
- Hits        16249    16246       -3     
- Misses      15547    15550       +3     
Impacted Files Coverage Δ
...pl/ompl_interface/src/planning_context_manager.cpp 54.37% <0.00%> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.36% <0.00%> (-1.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sjahr
Copy link
Contributor

sjahr commented Sep 29, 2022

Does the tutorial work for you? I tried to test your change but the robot never moved and I got stuck with the first example. Same happened with the last one (after I commented the ones before out) and I did not see the print statement you described above

@stephanie-eng
Copy link
Contributor Author

The tutorial doesn't work as per #1474 (comment), but Andy has a fix here: moveit/moveit2_tutorials#519

The print statement should appear as DEBUG, so you'll need to set your log level accordingly to see it.

Copy link
Member

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had this fixed a while ago... Backport to Humble, or other versions?

@henningkayser henningkayser added the backport-humble Mergify label that triggers a PR backport to Humble label Oct 28, 2022
@henningkayser henningkayser merged commit 67e08b7 into moveit:main Oct 28, 2022
mergify bot pushed a commit that referenced this pull request Oct 28, 2022
henningkayser pushed a commit that referenced this pull request Oct 28, 2022
…ckport #1589) (#1641)

(cherry picked from commit 67e08b7)

Co-authored-by: Stephanie Eng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixed constraints support issue
3 participants