Default to Cyclone DDS, remove deprecated time-param algorithms #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyZe
force-pushed
the
andyz/cyclone
branch
2 times, most recently
from
4c2fc31
to
1f65b69
Compare
|
I would suggest to clearly state this is a work-around for a known issue, and that this makes all nodes started using this RMW incompatible with any other nodes not using Cyclone DDS (due to ros2/rmw_cyclonedds#184). That last point is not something which is clear to many users, and I would expect novices trying the MoveIt 2 tutorials to be even less aware of something like this. |
AndyZe
force-pushed
the
andyz/cyclone
branch
from
1f65b69
to
4b6616e
Compare
AndyZe
force-pushed
the
andyz/cyclone
branch
from
a8bc06c
to
a9a6818
Compare
|
This pull request is in conflict. Could you fix it @AndyZe? |
JafarAbdi
approved these changes
Dec 15, 2022
vatanaksoytezer
approved these changes
Dec 15, 2022
AndyZe
changed the title
AndyZe
pushed a commit
to AndyZe/moveit2_tutorials
that referenced
this pull request
Dec 29, 2022
…it#519) * Recommend Cyclone DDS * Remove mentions of deprecated time-param algorithms Co-authored-by: Jafar <[email protected]>
AndyZe
pushed a commit
that referenced
this pull request
Dec 29, 2022
* Default to Cyclone DDS, remove deprecated time-param algorithms (#519) * Recommend Cyclone DDS * Remove mentions of deprecated time-param algorithms Co-authored-by: Jafar <[email protected]> * Fix the formatting of Cyclone commands (#559) * Fix the formatting of Cyclone commands * Link fixup * RMW clarification Co-authored-by: Sebastian Castro <[email protected]> Co-authored-by: Sebastian Castro <[email protected]> Co-authored-by: Jafar <[email protected]> Co-authored-by: Sebastian Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All of the tutorials using Move Group Interface are broken a.t.m. due to a FastDDS issue. Recommend a switch to Cyclone DDS as a workaround, as discussed here: moveit/moveit2#1474 (comment)