Add lookahead collator and enable async backing in all runtimes #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
added
a0-pleasereview
Agusrodri
commented
Mar 11, 2024
Coverage Report@@ Coverage Diff @@
## master agustin-lookahead-collator +/- ##
==============================================================
- Coverage 67.55% 65.08% -2.47%
+ Files 63 64 +1
+ Lines 9166 9515 +349
==============================================================
Hits 6192 6192
+ Misses 2974 3323 +349
|
|
@Agusrodri the zombienet tests do not work because you are pointing at a custom polkadot branch. Once you cherry-pick in the 1.6.0 branch all will be good |
Agusrodri
changed the title
Fixes a rare bug where collators will try to build a block before the runtime upgrade using the slot duration from the latest block, which is after the runtime upgrade, resulting in a stall
|
Let's not forget to modify the inflation rate to match the new expectations |
|
@Agusrodri make sure you merge master in please, that should make your tests more robust against the CI |
This was referenced Mar 19, 2024
Merged
girazoki
reviewed
Mar 19, 2024
girazoki
reviewed
Mar 19, 2024
girazoki
approved these changes
Mar 19, 2024
girazoki
reviewed
Mar 19, 2024
girazoki
reviewed
Mar 19, 2024
ParthDesai
reviewed
Mar 20, 2024
tmpolaczyk
approved these changes
Mar 21, 2024
ParthDesai
reviewed
Mar 21, 2024
ParthDesai
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Following #399, this PR adds an implementation for the
lookaheadcollator client.With this collator, we now can enable asynchronous backing and leverage all its new functionalities, like the six seconds blocktime and also producing parachain blocks on top of other para-blocks that were not included in the relay yet (unincluded segment). Without the
lookaheadcollator, these features could not be implemented as the other kind of collator (basic) allows to produce blocks only in the old way without async-backing enabled.