-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt client to support asynchronous backing #399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
added
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
breaking
Needs to be mentioned in breaking changes
labels
Jan 31, 2024
Coverage Report@@ Coverage Diff @@
## master agustin-client-async-backing +/- ##
================================================================
- Coverage 77.30% 75.86% -1.44%
+ Files 105 107 +2
- Lines 26797 25928 -869
================================================================
- Hits 20715 19668 -1047
+ Misses 6082 6260 +178
|
tmpolaczyk
reviewed
Jan 31, 2024
all tests pass? wow |
tmpolaczyk
reviewed
Feb 1, 2024
tmpolaczyk
reviewed
Feb 2, 2024
tmpolaczyk
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
girazoki
reviewed
Feb 5, 2024
girazoki
reviewed
Feb 5, 2024
girazoki
reviewed
Feb 5, 2024
girazoki
reviewed
Feb 5, 2024
girazoki
reviewed
Feb 5, 2024
girazoki
reviewed
Feb 5, 2024
girazoki
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good overall!
Agusrodri
changed the title
WIP: Adapt client to support asynchronous backing
Adapt client to support asynchronous backing
Feb 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
B5-clientnoteworthy
Changes should be mentioned in any downstream projects' release notes
breaking
Needs to be mentioned in breaking changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the client to support future async backing, adapting it to the new kind of aura params.
Main changes
This PR refactors the way of handling how collators are spawned, from both the orchestrator and container-chains sides.
It deprecates the usage of
OrchestratorAuraConsensus
struct, alongside with its associatedOrchestratorAuraWorker
and related params.The new approach consists on adding a new Collator struct, which has the following params:
At the moment of spawning the node, the collators will wake up using a
run
function, that will be called using custom params (basic
orlookahead
ones) depending on if we are spawning the collator with async-backing enabled or not. Thus,basic
params will be used without async-backing andlookahead
ones will be used to spawn the node using the async-backing functionality.Note
The
lookahead
implementation will be added in a future PR, when we are closer to enabling async-backing also at a runtime level.