Re-work client tests #407
Merged
Re-work client tests #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
added
B0-silent
Coverage Report@@ Coverage Diff @@
## master agustin-client-tests-rework +/- ##
===============================================================
+ Coverage 75.93% 77.02% +1.09%
Files 107 107
- Lines 26746 26687 -59
===============================================================
+ Hits 20309 20554 +245
- Misses 6437 6133 -304
|
girazoki
approved these changes
Feb 12, 2024
tmpolaczyk
reviewed
Feb 12, 2024
tmpolaczyk
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous work for #399 we removed some tests in the client related to the old consensus model. This PR re-includes and adapts them to the new kind of collator params.