Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Moonkit fork Reference #467

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Update Moonkit fork Reference #467

merged 3 commits into from
Mar 19, 2024

Conversation

ParthDesai
Copy link
Contributor

Description

This PR updates moonkit fork reference for tanssi.

The first commit updates the commit reference in Cargo.lock. Second commit changes the runtimes to add the new types added in Config trait of some pallets.

@ParthDesai ParthDesai added B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Mar 19, 2024
@ParthDesai ParthDesai requested a review from girazoki March 19, 2024 14:56
@girazoki
Copy link
Collaborator

this is going to create conflicts potentially with #448, maybe we should wait for that to merge?

@ParthDesai
Copy link
Contributor Author

this is going to create conflicts potentially with #448, maybe we should wait for that to merge?

This means that I am blocked for the next part (adding dummy precompile) till this is merged. I will switch over to another task in the meanwhile.

@girazoki
Copy link
Collaborator

yep, no worries

Copy link
Contributor

github-actions bot commented Mar 19, 2024

Coverage Report

(master)

@@                    Coverage Diff                     @@
##           master   update-moonkit-fork-ref     +/-   ##
==========================================================
  Coverage   67.55%                    67.55%   0.00%     
  Files          63                        63             
  Lines        9166                      9166             
==========================================================
  Hits         6192                      6192             
  Misses       2974                      2974             
Files Changed Coverage

Coverage generated Tue Mar 19 18:16:35 UTC 2024

@ParthDesai ParthDesai merged commit 0a5e601 into master Mar 19, 2024
32 checks passed
@ParthDesai ParthDesai deleted the update-moonkit-fork-ref branch March 19, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants