Make the sniff to also detect unexpected MOODLE_INTERNAL checks

[stronk7]

Until now, the Sniff was only finding missing MOODLE_INTERNAL checks
(when the file has side effects OR multiple artifacts).

Now, when the check exists and the file does not have side effects
or multiple artifacts, a new MoodleInternalNotNeeded is thrown.

Also, when the old MOODLE_INTERNAL check is detected, a new
MoodleInternalOld warning is thrown.

Covered with tests.

Finally, all the tests related with this Sniff have been moved
to a different test case and all the fixtures moved to new
subdirectory. Part of plans to split the tests completely, with
each sniff having its own testcase.

Fixes #152

[stronk7]

Here there are the results of the Sniff against complete (master) codebase:

https://gist.github.com/stronk7/162e4b652490e02d66164606edb00864

9604 errors and 500 warnings.

Ciao :-)

[lucaboesch]

You have included the vendor directory, Eloy.

[stronk7]

You have included the vendor directory, Eloy.

Yeah, and all third-party libs and others. Not critical. Neither the numbers are important or are going to be fixes in bulk. Still there are a lot.

Thanks!

[danmarsden]

did this one really need to be an "error" state?
https://github.com/moodlehq/moodle-local_codechecker/pull/169/files#diff-a1e9c2ff7e45d5b92bf1baa5e465b8256f040c133fe1fad55a2da5536e3aeafaR125

I'm seeing this error in some pull requests this week on 3rd party plugins, and it doesn't really feel that important.. maybe it could have been a warning and then upgraded to an error at a later date?

[scara]

Hi @danmarsden,
FYI #174.

HTH,
Matteo

[danmarsden]

cool thanks - should have checked existing issues! :-)

[stronk7]

Yeah, my fault, the new check was incepted to be a warning but I forgot that completely and went the radical/error way.

Yep, #174 will, hopefully soon (planning new releases for as soon as today), fix that (thanks @scara).