Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD Pipeline is broken: fix code checker #92

Merged
merged 1 commit into from
Jan 18, 2022
Merged

CI/CD Pipeline is broken: fix code checker #92

merged 1 commit into from
Jan 18, 2022

Conversation

icaparros-at-wiris
Copy link
Contributor

Description

The dependency moodle-plugin-ci that we use to test and analyze our Moodle suit projects code, has been updated to 3.2.3, introducing the following changes:

This change affects directly to our GitHub Actions workflow, it makes it fail, hence it does not allow us to make new releases of the Moodle suite.

Implementation:

The new release of the moodle-plugin-ci dependency claims that, all PHP files without side-effects must remove unnecessary MOODLE_INTERNAL requirements.

defined('MOODLE_INTERNAL') || die();

What is included on this PR:

This PR also includes:

  • There are also other linting issues that can cause errors, so they were removed:
    • Open brackets can not start in a new line.
    • PHP classes must have the same name as the file.
    • Remove unnecessary space & jump spaces.
  • Updated CHANGELOG

Steps to reproduce

  • On the Actions tab, find the "Moodle Plugin CI" workflow.
  • Use the workflow dispatch option on the KB-19424 branch.
  • All moodle code checker verifications should pass without warnings or errors.

Check Github actions results.

#taskid 19424

@icaparros-at-wiris icaparros-at-wiris added the type:bug Something isn't working label Jan 18, 2022
@icaparros-at-wiris icaparros-at-wiris self-assigned this Jan 18, 2022
@icaparros-at-wiris icaparros-at-wiris force-pushed the KB-19424 branch 2 times, most recently from 23495ce to 358cbab Compare January 18, 2022 11:57
@dcanet-at-wiris @icaparros-at-wiris
fix(ci): moodle code checker warning and errors
51aa9d6 
Removed unnecessary MOODLE_INTERNAL defines.
Resolved linting php errors; unnecessary jumpspaces,
class names and brackets positions.

#taskid 19424
dcanet-at-wiris
dcanet-at-wiris approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@dcanet-at-wiris dcanet-at-wiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge. 👍🏿

Great pull request, btw.
Kudos to you and @carla-at-wiris.

@carla-at-wiris carla-at-wiris merged commit 2223cf8 into main Jan 18, 2022
@carla-at-wiris carla-at-wiris deleted the KB-19424 branch January 18, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcanet-at-wiris dcanet-at-wiris dcanet-at-wiris approved these changes

@carla-at-wiris carla-at-wiris carla-at-wiris approved these changes

@xripoll-at-wiris xripoll-at-wiris Awaiting requested review from xripoll-at-wiris

Assignees

@icaparros-at-wiris icaparros-at-wiris

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icaparros-at-wiris @carla-at-wiris @dcanet-at-wiris