Downgrade to warning the new MoodleInternalNotNeeded error #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the new detection was planned at moodlehq#152, it was agreed to make it a warning, not an error. Instead, I missed that completely and implemented it as error. So, this simple PR just downgrades the check to warning, as originally planned.
stronk7
force-pushed
the
unexpected_is_warning
branch
from
8a7ab1f to
d887465
Compare
ilyatregubov
approved these changes
Jan 17, 2022
|
Thanks @ilyatregubov ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the new detection was planned at #152, it was agreed
to make it a warning, not an error.
Instead, I missed that completely and implemented it as error.
So, this simple PR just downgrades the check to warning, as
originally planned.
With this patch applied, this will be the behavior:
That behavior matches the agreement @ https://tracker.moodle.org/browse/MDLSITE-5967 plus add the new/remaining warning about unexpected MOODLE_INTERNAL checks.