Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: In smart menus, the search for cohorts in restrict visibility by cohorts didn't work for more than 25 cohorts, resolves #462. #615

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

abias
Copy link
Member

@abias abias commented Mar 31, 2024

No description provided.

Copy link

@cjbsdigitallearning cjbsdigitallearning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very straight forward fix to the cohort_get_all_cohorts() call.

… by cohorts didn't work for more than 25 cohorts, resolves #462.
@abias
Copy link
Member Author

abias commented Apr 2, 2024

Thank you @cjbsdigitallearning for confirming the fix!
I will merge the PR then.

@abias abias merged commit 420ac1e into master Apr 2, 2024
11 of 12 checks passed
@abias abias deleted the issue-462 branch April 2, 2024 19:14
abias added a commit that referenced this pull request Apr 6, 2024
… by cohorts didn't work for more than 25 cohorts, resolves #462. (#615)
abias added a commit that referenced this pull request Apr 6, 2024
… by cohorts didn't work for more than 25 cohorts, resolves #462. (#615)
abias added a commit that referenced this pull request Apr 6, 2024
… by cohorts didn't work for more than 25 cohorts, resolves #462. (#615)
abias added a commit that referenced this pull request Apr 6, 2024
… by cohorts didn't work for more than 25 cohorts, resolves #462. (#615)
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smart Menus: search of cohort in restrict visibility by cohorts doesn't work properly
2 participants