Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: In smart menus, the search for cohorts in restrict visibility by cohorts didn't work for more than 25 cohorts, resolves #462. #615

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Bugfix: In smart menus, the search for cohorts in restrict visibility by cohorts didn't work for more than 25 cohorts, resolves #462. #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Changes

### Unreleased

* 2024-04-01 - Bugfix: In smart menus, the search for cohorts in restrict visibility by cohorts didn't work for more than 25 cohorts, resolves #462.
* 2024-04-01 - Improvement: Enhance the activitynavigation setting description to cover section navigation as well, resolves #536.
* 2024-03-30 - Bugfix: Smart menu divider did not work for user menu submenus, resolves #537.
* 2024-03-25 - Upgrade: Boost Union settings were moved to an admin settings category of its own to support the new theme chooser on Moodle 4.4, resolves #482.
Expand Down
2 changes: 1 addition & 1 deletion classes/form/smartmenu_edit_form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ public function definition() {
}

// Add by cohorts as autocomplete element.
$cohortslist = \cohort_get_all_cohorts();
$cohortslist = \cohort_get_all_cohorts(0, 0);
$cohortoptions = $cohortslist['cohorts'];
if ($cohortoptions) {
array_walk($cohortoptions, function(&$value) {
Expand Down
2 changes: 1 addition & 1 deletion classes/form/smartmenu_item_edit_form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ public function definition() {
}

// Add by cohorts as autocomplete element.
$cohortslist = \cohort_get_all_cohorts();
$cohortslist = \cohort_get_all_cohorts(0, 0);
$cohortoptions = $cohortslist['cohorts'];
if ($cohortoptions) {
array_walk($cohortoptions, function(&$value) {
Expand Down
Loading