Bugfix: In smart menus, the search for cohorts in restrict visibility…

… by cohorts didn't work for more than 25 cohorts, resolves moodle-an-hochschulen#462. (moodle-an-hochschulen#615)
detomon · Apr 2, 2024 · 37efa6f · 37efa6f
1 parent f430ab4
commit 37efa6f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -6,6 +6,7 @@ Changes
 
 ### Unreleased
 
+* 2024-04-01 - Bugfix: In smart menus, the search for cohorts in restrict visibility by cohorts didn't work for more than 25 cohorts, resolves #462.
 * 2024-04-01 - Improvement: Enhance the activitynavigation setting description to cover section navigation as well, resolves #536.
 * 2024-03-30 - Bugfix: Smart menu divider did not work for user menu submenus, resolves #537.
 * 2024-03-25 - Upgrade: Boost Union settings were moved to an admin settings category of its own to support the new theme chooser on Moodle 4.4, resolves #482.

diff --git a/classes/form/smartmenu_edit_form.php b/classes/form/smartmenu_edit_form.php
@@ -215,7 +215,7 @@ public function definition() {
         }
 
         // Add by cohorts as autocomplete element.
-        $cohortslist = \cohort_get_all_cohorts();
+        $cohortslist = \cohort_get_all_cohorts(0, 0);
         $cohortoptions = $cohortslist['cohorts'];
         if ($cohortoptions) {
             array_walk($cohortoptions, function(&$value) {

diff --git a/classes/form/smartmenu_item_edit_form.php b/classes/form/smartmenu_item_edit_form.php
@@ -385,7 +385,7 @@ public function definition() {
         }
 
         // Add by cohorts as autocomplete element.
-        $cohortslist = \cohort_get_all_cohorts();
+        $cohortslist = \cohort_get_all_cohorts(0, 0);
         $cohortoptions = $cohortslist['cohorts'];
         if ($cohortoptions) {
             array_walk($cohortoptions, function(&$value) {