Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds remembering of active admin tab on page reload. #341

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

mwehr
Copy link
Collaborator

@mwehr mwehr commented Jul 17, 2023

This adds remembering the active tab in boost union admin settings on page reload. resolves #468

@abias
Copy link
Member

abias commented Nov 8, 2023

Hi @mwehr ,

many thanks for submitting the PR and sorry that it remained unhandled for so long.
We are just ramping up or PR reviewing again after we have established some more processes to keep the overview over our work.

As a result, we have created a board on https://github.com/orgs/moodle-an-hochschulen/projects/4/views/1 and have established a policy that every PR needs a corresponding issue which it solves.

May I ask you to quickly create a Github issue with a brief explanation of the goal which this PR tries to solve? I will then be able to add your issue to the board and review your PR.

Thanks,
Alex

abias
abias previously approved these changes Mar 19, 2024
Copy link
Member

@abias abias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mwehr ,

many thanks for this contribution and sorry that it remained unhandled for so long!

This is a really helpful addition to Boost Union for all admins who have to handle the same settings page again and again as they are doing multiple theme configurations in a row or want to test multiple values of the same setting.

I just rebased your PR branch onto the latest master and have reviewed your PR.

The review was quite easy. I just made some tiny refactorings and made the comments more verbose to match the current Boost Union codebase.
I also added a version bump (as a JS module has been added and the JS cache should be cleared after installing this patch), an entry in CHANGES.md and a Behat scenario.

I did not add an admin setting to enable this feature (like we normally do) and did not add a note to README about this feature as well. My understanding is that this is not necessary as it's a 100% admin-only feature and should "just work".

I will merge the PR as soon as the tests are green again.

Cheers,
Alex

@abias abias merged commit b870a6e into moodle-an-hochschulen:master Mar 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remembering of active boost union admin sub-tab after save and page reload
2 participants