Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Add prefixes to the sessionStorage keys in the scrollspy implementation. #598

Closed
abias opened this issue Mar 18, 2024 · 0 comments
Closed

Improvement: Add prefixes to the sessionStorage keys in the scrollspy implementation. #598

abias opened this issue Mar 18, 2024 · 0 comments
Assignees
@abias
Labels
improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)

Comments

@abias
Copy link
Member

abias commented Mar 18, 2024

During the review of #341, I realized that in the scrollspy implementation, quite short and non-prefixed session keys are used. While it is unlikely, this could cause key colissions anytime in the future.

It would be worthwhile to add prefixes to the session keys.
@abias abias added the improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality) label Mar 18, 2024
@abias abias self-assigned this Mar 18, 2024
@abias abias changed the title Improvement: Improvement: Add prefixes to the sessionStorage keys in the scrollspy implementation. Mar 18, 2024
abias added a commit that referenced this issue Mar 18, 2024
@abias
Improvement: Add prefixes to the sessionStorage keys in the scrollspy…
1171b24 
… implementation, resolves #598.
abias added a commit that referenced this issue Mar 19, 2024
@abias
Improvement: Add prefixes to the sessionStorage keys in the scrollspy…
5e6a314 
… implementation, resolves #598.
@abias abias closed this as completed in 2a08c72 Mar 19, 2024
@github-project-automation github-project-automation bot moved this to Ready for Release Test in Boost Union Planning Board Mar 19, 2024
abias added a commit that referenced this issue Mar 23, 2024
@abias
Improvement: Add prefixes to the sessionStorage keys in the scrollspy…
9fef595 
… implementation, resolves #598. (#599)
abias added a commit that referenced this issue Mar 23, 2024
@abias
Improvement: Add prefixes to the sessionStorage keys in the scrollspy…
722d018 
… implementation, resolves #598. (#599)
abias added a commit that referenced this issue Mar 23, 2024
@abias
Improvement: Add prefixes to the sessionStorage keys in the scrollspy…
175c319 
… implementation, resolves #598. (#599)
@abias abias moved this from Ready for Release Test to CLOSED in Boost Union Planning Board Mar 23, 2024
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@abias
Improvement: Add prefixes to the sessionStorage keys in the scrollspy…
397e383 
… implementation, resolves moodle-an-hochschulen#598. (moodle-an-hochschulen#599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abias abias

Labels
improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)
Projects
Boost Union Planning Board
Status: CLOSED
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abias