Improvement: Add prefixes to the sessionStorage keys in the scrollspy…

… implementation, resolves #598.
moodle-an-hochschulen · Mar 18, 2024 · 1171b24 · 1171b24
1 parent 1e48934
commit 1171b24
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 11 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,6 +4,10 @@ moodle-theme_boost_union
 Changes
 -------
 
+### Unreleased
+
+* 2024-03-18 - Improvement: Add prefixes to the sessionStorage keys in the scrollspy implementation, resolves #598.
+
 ### v4.3-r9
 
 * 2024-03-13 - Improvement: In smart menus, dynamic courses can now pick up the courses from all subcategories, resolves #395.

diff --git a/amd/build/scrollspy.min.js b/amd/build/scrollspy.min.js
diff --git a/amd/build/scrollspy.min.js.map b/amd/build/scrollspy.min.js.map
diff --git a/amd/src/scrollspy.js b/amd/src/scrollspy.js
@@ -44,7 +44,7 @@ const initScrollSpy = () => {
         }
         editToggle.addEventListener('click', () => {
 
-            window.sessionStorage.setItem('edittoggled', true);
+            window.sessionStorage.setItem('theme_boost_union_scrollspy_edittoggled', true);
 
             let viewporttop = window.scrollY;
             let closest = null;
@@ -61,14 +61,14 @@ const initScrollSpy = () => {
                 }
             });
 
-            window.sessionStorage.setItem('closestid', closest.id);
-            window.sessionStorage.setItem('closestdelta', viewporttop - closest.offsetTop);
+            window.sessionStorage.setItem('theme_boost_union_scrollspy_closestid', closest.id);
+            window.sessionStorage.setItem('theme_boost_union_scrollspy_closestdelta', viewporttop - closest.offsetTop);
         });
-        let edittoggled = window.sessionStorage.getItem('edittoggled');
+        let edittoggled = window.sessionStorage.getItem('theme_boost_union_scrollspy_edittoggled');
         if (edittoggled) {
 
-            let closestid = window.sessionStorage.getItem('closestid');
-            let closestdelta = window.sessionStorage.getItem('closestdelta');
+            let closestid = window.sessionStorage.getItem('theme_boost_union_scrollspy_closestid');
+            let closestdelta = window.sessionStorage.getItem('theme_boost_union_scrollspy_closestdelta');
 
             if (closestid && closestdelta) {
                 let closest = document.getElementById(closestid);
@@ -77,9 +77,9 @@ const initScrollSpy = () => {
                 window.scrollTo(0, y);
             }
 
-            window.sessionStorage.removeItem('edittoggled');
-            window.sessionStorage.removeItem('closestid');
-            window.sessionStorage.removeItem('closestdelta');
+            window.sessionStorage.removeItem('theme_boost_union_scrollspy_edittoggled');
+            window.sessionStorage.removeItem('theme_boost_union_scrollspy_closestid');
+            window.sessionStorage.removeItem('theme_boost_union_scrollspy_closestdelta');
         }
     }
 };