Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remembering of active boost union admin sub-tab after save and page reload #468

Closed
mwehr opened this issue Nov 9, 2023 · 2 comments · Fixed by #341
Closed

Remembering of active boost union admin sub-tab after save and page reload #468

mwehr opened this issue Nov 9, 2023 · 2 comments · Fixed by #341
Assignees
Labels
improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)

Comments

@mwehr
Copy link
Collaborator

mwehr commented Nov 9, 2023

If you change a value in the sub-tabs of the Boost Union Admin setting, the first tab is always selected after reloading the page and not the current tab in which the change was made.

It would be helpful if the current Boost Union sub-tab is opened again after saving and reloading the admin settings page.

@mwehr mwehr added the new Something which has been reported but has not yet beeen triaged by the team label Nov 9, 2023
@whuml whuml added improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality) and removed new Something which has been reported but has not yet beeen triaged by the team labels Nov 16, 2023
@whuml whuml moved this to Ready for DEV in Boost Union Planning Board Nov 16, 2023
@wiebkemueller-hsh wiebkemueller-hsh moved this from Ready for DEV to Ready for TEST in Boost Union Planning Board Nov 23, 2023
@elz-hwr elz-hwr moved this from Ready for TEST to In Progress TEST in Boost Union Planning Board Feb 20, 2024
@elz-hwr
Copy link
Collaborator

elz-hwr commented Feb 21, 2024

Functionally, the desired effect is achieved: after changing and saving a boost union value, the active setting bar remains open.
Tested in version 4.3.2/4.3.3

No idea how important the following information is, but just to be on the safe side:
The following debug message occurred in both versions:

user_preference_allow_ajax_update() is deprecated. Please use the "core_user/repository" module instead.

    line 41 of /lib/ajax/ajaxlib.php: call to debugging()
    line 59 of /theme/boost_union/layout/drawers.php: call to user_preference_allow_ajax_update()
    line 1486 of /lib/outputrenderers.php: call to include()
    line 1412 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
    line 116 of /index.php: call to core_renderer->header()

user_preference_allow_ajax_update() is deprecated. Please use the "core_user/repository" module instead.

    line 41 of /lib/ajax/ajaxlib.php: call to debugging()
    line 60 of /theme/boost_union/layout/drawers.php: call to user_preference_allow_ajax_update()
    line 1486 of /lib/outputrenderers.php: call to include()
    line 1412 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
    line 134 of /admin/settings.php: call to core_renderer->header()


Deprecated: Creation of dynamic property additionalregions::$regions is deprecated in /var/www/html/theme/boost_union/layout/includes/blockregions.php on line 50

@elz-hwr elz-hwr moved this from In Progress TEST to Ready for REVIEW in Boost Union Planning Board Feb 21, 2024
@abias abias moved this from Ready for REVIEW to In Progress REVIEW in Boost Union Planning Board Mar 18, 2024
@abias
Copy link
Member

abias commented Mar 18, 2024

Thank you @elz-hwr for testing the PR which belongs to this issue!
I think the deprecation warnings which you saw resulted from the fact that the PR is quite outdated and based on a Boost Union 4.1 release, but you tested it on 4.2 / 4.3 where user_preference_allow_ajax_update() was deprecated in Moodle core. No need to worry, I will take care of that during the review of the PR.

abias added a commit that referenced this issue Mar 19, 2024
…ing a setting and the following page reload, resolves #468.
@github-project-automation github-project-automation bot moved this from In Progress REVIEW to Ready for Release Test in Boost Union Planning Board Mar 19, 2024
@abias abias moved this from Ready for Release Test to CLOSED in Boost Union Planning Board Mar 23, 2024
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)
Projects
Status: CLOSED
Development

Successfully merging a pull request may close this issue.

4 participants