Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Streamlining of content width sizing #18

Closed
ShUl0w opened this issue Mar 22, 2022 · 7 comments
Closed

Proposal: Streamlining of content width sizing #18

ShUl0w opened this issue Mar 22, 2022 · 7 comments
Labels
discussion needed Something which needs to be discussed before writing the first line of code feature Something which is a new feature or big improvement improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)

Comments

@ShUl0w
Copy link
Collaborator

ShUl0w commented Mar 22, 2022

In its current form, the new Moodle 4.0 UI uses an inconsistent approach to content sizing for center column content. This is especially notable on pages where the center column alternates between a .container for its course related contents (e.g. course navigation), and a .container-fluid for elements that contain tables etc. (e.g. gradebook).

This becomes even more of a problem when modals are involved, as they seem to always use a .container, which in turn loses precious screen real estate; the new question bank UI is a good example of this.

Given how the 4.0 UI is already trying to use the full screen width by including a drawer on the left and right side of the screen respectively, I propose to streamline the content width across all screens if possible and simultaneously increase the size of the center column. Adapting the drawers to reduce the middle column size when visible shouldn't be that much of a problem.

@lucaboesch
Copy link
Collaborator

Liebe @ShUl0w kontrollier doch mal nachdem heute MDL-74062 integriert wurde, an welchen Stellen dies noch auftritt.

@ShUl0w
Copy link
Collaborator Author

ShUl0w commented Mar 22, 2022

Hey @lucaboesch, in dem von Dir verlinkten Issue geht es darum, dass die Navi in Kursen eine durchgängige max-width besitzt - darauf wollte ich aber nicht hinaus; vielmehr wollte ich auf das Ergebnis der Schritte 1-5 hinaus.

Vgl. hierzu die von mir angehängten Screenshots (basierend auf dem aktuellen Master-Branch):
Screenshot 2022-03-22 at 17 42 29
Screenshot 2022-03-22 at 17 44 12

Die Tatsache, dass in der Kursansicht die Navigation eine Max-Width besitzt, die Einstellungen zu einer Quiz-Frage hingegen nicht sorgt für einen sehr unruhigen Seitenaufbau. Content in einem Modal wiederum orientiert sich an der Breite des Navigations-Containers.

Mein Proposal zielte dementsprechend darauf ab, a) diesen Seitenaufbau zu vereinheitlichen und b) die Center-Column allgemein breiter zu machen - für Mobilgeräte ist die Seite bereits responsiv, dafür leidet nun die Usability auf dem Desktop.

@dbnschools
Copy link

$course-content-maxwidth: 100% !default;
makes the pages all full-width. Drop it in the Raw SCSS box of Boost.

@abias abias added the discussion needed Something which needs to be discussed before writing the first line of code label Apr 14, 2022
abias added a commit that referenced this issue Jul 7, 2022
…esolve #18.

With this patch, admins can override Moodle's default content width without manual SCSS modifications.
@abias
Copy link
Member

abias commented Jul 7, 2022

In #45, I just submitted a PR which allows admins to overwrite the $course-content-maxwidth SCSS variable in the GUI. This can help to resolve this issue, but I assume that it is not sufficient at all.

abias added a commit that referenced this issue Jul 7, 2022
…esolve #18.

With this patch, admins can override Moodle's default content width without manual SCSS modifications.
abias added a commit that referenced this issue Jul 7, 2022
…esolve #18.

With this patch, admins can override Moodle's default content width without manual SCSS modifications.
abias added a commit that referenced this issue Jul 7, 2022
…esolve #18.

With this patch, admins can override Moodle's default content width without manual SCSS modifications.
lucaboesch added a commit that referenced this issue Jul 8, 2022
Feature: Make the course content column width configurable, helps to resolve #18.
@abias abias reopened this Jul 8, 2022
@abias
Copy link
Member

abias commented Jul 8, 2022

#18 closed this automatically.
I reopen this issue for further discussions

@ralf-krause
Copy link
Contributor

Yes, I like the feature for setting the course width to 1200px for large displays.
But it would also be nice to reduce the borders on the right and the left side for small displays as we have with smartphones or tablets. I tested this in the raw scss section.

/* Seitenränder für kleine Displays reduzieren */
@media (max-width: 767.98px) { 
#page.drawers, #page.drawers div[role="main"] { padding: 0 3px 0 3px; } 
}
@media (min-width: 768px) { 
#page.drawers { padding: 0 10px 0 10px; } 
}

@wiebkemueller-hsh wiebkemueller-hsh added improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality) feature Something which is a new feature or big improvement and removed improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality) labels Aug 21, 2023
@wiebkemueller-hsh wiebkemueller-hsh added the improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality) label Oct 2, 2023
@wiebkemueller-hsh
Copy link
Collaborator

As discussed with @ShUl0w this can be closed!

@github-project-automation github-project-automation bot moved this to Ready for Release Test in Boost Union Planning Board Mar 14, 2024
@wiebkemueller-hsh wiebkemueller-hsh moved this from Ready for Release Test to CLOSED in Boost Union Planning Board Mar 14, 2024
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
…esolve moodle-an-hochschulen#18.

With this patch, admins can override Moodle's default content width without manual SCSS modifications.
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
…n/issue-18-partly

Feature: Make the course content column width configurable, helps to resolve moodle-an-hochschulen#18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needed Something which needs to be discussed before writing the first line of code feature Something which is a new feature or big improvement improvement Something which improves an existing feature in some way (UX, UI, Design, Functionality)
Projects
Status: CLOSED
Development

No branches or pull requests

6 participants