-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Streamlining of content width sizing #18
Comments
Hey @lucaboesch, in dem von Dir verlinkten Issue geht es darum, dass die Navi in Kursen eine durchgängige max-width besitzt - darauf wollte ich aber nicht hinaus; vielmehr wollte ich auf das Ergebnis der Schritte 1-5 hinaus. Vgl. hierzu die von mir angehängten Screenshots (basierend auf dem aktuellen Master-Branch): Die Tatsache, dass in der Kursansicht die Navigation eine Max-Width besitzt, die Einstellungen zu einer Quiz-Frage hingegen nicht sorgt für einen sehr unruhigen Seitenaufbau. Content in einem Modal wiederum orientiert sich an der Breite des Navigations-Containers. Mein Proposal zielte dementsprechend darauf ab, a) diesen Seitenaufbau zu vereinheitlichen und b) die Center-Column allgemein breiter zu machen - für Mobilgeräte ist die Seite bereits responsiv, dafür leidet nun die Usability auf dem Desktop. |
$course-content-maxwidth: 100% !default; |
…esolve #18. With this patch, admins can override Moodle's default content width without manual SCSS modifications.
In #45, I just submitted a PR which allows admins to overwrite the $course-content-maxwidth SCSS variable in the GUI. This can help to resolve this issue, but I assume that it is not sufficient at all. |
…esolve #18. With this patch, admins can override Moodle's default content width without manual SCSS modifications.
…esolve #18. With this patch, admins can override Moodle's default content width without manual SCSS modifications.
…esolve #18. With this patch, admins can override Moodle's default content width without manual SCSS modifications.
Feature: Make the course content column width configurable, helps to resolve #18.
#18 closed this automatically. |
Yes, I like the feature for setting the course width to 1200px for large displays.
|
As discussed with @ShUl0w this can be closed! |
…esolve moodle-an-hochschulen#18. With this patch, admins can override Moodle's default content width without manual SCSS modifications.
…n/issue-18-partly Feature: Make the course content column width configurable, helps to resolve moodle-an-hochschulen#18.
In its current form, the new Moodle 4.0 UI uses an inconsistent approach to content sizing for center column content. This is especially notable on pages where the center column alternates between a .container for its course related contents (e.g. course navigation), and a .container-fluid for elements that contain tables etc. (e.g. gradebook).
This becomes even more of a problem when modals are involved, as they seem to always use a .container, which in turn loses precious screen real estate; the new question bank UI is a good example of this.
Given how the 4.0 UI is already trying to use the full screen width by including a drawer on the left and right side of the screen respectively, I propose to streamline the content width across all screens if possible and simultaneously increase the size of the center column. Adapting the drawers to reduce the middle column size when visible shouldn't be that much of a problem.
The text was updated successfully, but these errors were encountered: