Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow the admin to change the H5P content bank width, solves #201 #202

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

abias
Copy link
Member

@abias abias commented Jan 22, 2023

No description provided.

@abias
Copy link
Member Author

abias commented Jan 23, 2023

After @lucaboesch 's (private) feedback for me, I realized that this SCSS variable only applies to the H5P content in the content bank, but does not apply to H5P content within the H5P activity. That's sad but true.
However, I have modified the setting descriptions so we can still merge this feature in - although it is only a minor feature anoymore.

In #18, we can still discuss further improvements on content width.

@abias abias changed the title Feature: Allow the admin to change the H5P content width, solves #201 Feature: Allow the admin to change the H5P content bank width, solves #201 Jan 23, 2023
Copy link
Collaborator

@lucaboesch lucaboesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@lucaboesch
Copy link
Collaborator

This looks good.
Merging.

@lucaboesch lucaboesch merged commit aaaffbe into master Jan 24, 2023
@lucaboesch lucaboesch deleted the issue-201 branch January 24, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants