Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make the course content column width configurable, helps to resolve #18. #45

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

abias
Copy link
Member

@abias abias commented Jul 7, 2022

With this patch, admins can override Moodle's default content width without manual SCSS modifications.


Please note that this PR is built on top of PR #43 and should be merged in line.

Copy link
Collaborator

@lucaboesch lucaboesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also allow vw (Viewport Width) as unit?

@abias abias force-pushed the issue-18-partly branch from 5cf9388 to 8df51c5 Compare July 7, 2022 12:02
@abias
Copy link
Member Author

abias commented Jul 7, 2022

Maybe also allow vw (Viewport Width) as unit?

Sure, why not. I have amended the PR.

abias added 2 commits July 8, 2022 08:12
This patch allows the admin to enable a imprint page which can be filled with custom content.
Additionally, the link to the imprint page can be added to the footnote or the footer automatically.

This feature is particularly intended to be an easier-to-use replacement for local_staticpage and other third party solutions if you just need to add an imprint to your site.
…esolve #18.

With this patch, admins can override Moodle's default content width without manual SCSS modifications.
@abias abias force-pushed the issue-18-partly branch from 8df51c5 to 0208edc Compare July 8, 2022 06:14
Copy link
Collaborator

@lucaboesch lucaboesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good. The passed over value is reflected in the output CSS e.g. max-width: 1020px (in several places).

@lucaboesch lucaboesch merged commit 24d9c38 into master Jul 8, 2022
@lucaboesch lucaboesch deleted the issue-18-partly branch July 8, 2022 08:31
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this pull request Aug 26, 2024
…n/issue-18-partly

Feature: Make the course content column width configurable, helps to resolve moodle-an-hochschulen#18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants