Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Adjust type of set structure in team update logic #2675

Merged
merged 2 commits into from
Oct 10, 2024
Merged

refactor: Adjust type of set structure in team update logic #2675

merged 2 commits into from
Oct 10, 2024

Conversation

AgustinBettati
Copy link
Member

Description

Follow up from #2669 (comment)

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@AgustinBettati AgustinBettati marked this pull request as ready for review October 10, 2024 08:57
@AgustinBettati AgustinBettati requested a review from a team as a code owner October 10, 2024 08:57
@AgustinBettati AgustinBettati mentioned this pull request Oct 10, 2024
Merged
13 tasks
EspenAlbert
EspenAlbert reviewed Oct 10, 2024
View reviewed changes
tools/check-changelog-entry-file/main.go
@@ -12,7 +12,7 @@ import (

var (
skipLabelName = "skip-changelog-check"
skipTitles = []string{"chore", "test", "doc", "ci"} // Dependabot uses chore.
skipTitles = []string{"chore", "test", "doc", "ci", "refactor"} // Dependabot uses chore.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@AgustinBettati AgustinBettati merged commit 3669465 into master Oct 10, 2024
41 checks passed
@AgustinBettati AgustinBettati deleted the CLOUDP-277323-followup branch October 10, 2024 10:43
@lantoli
Copy link
Member

lantoli commented Oct 10, 2024

thanks @AgustinBettati for following this up

lantoli added a commit that referenced this pull request Oct 16, 2024
@lantoli
Merge branch 'master' into moved_old_tf_version
836882a 
* master: (44 commits)
  Remove RemoveResource from Create and Update (#2694)
  sleep first time only (#2696)
  fix: Ensures event_trigger `disabled` is included in the PUT payload (#2690)
  chore: Bump srvaroa/labeler from 1.11.0 to 1.11.1 (#2695)
  build(deps): bump go.mongodb.org/atlas-sdk (#2686)
  fix: Avoids setting organization id to empty when the USER_IS_NOT_FOUND (#2684)
  doc: Corrects default value of `auto_scaling_disk_gb_enabled` (#2683)
  chore: Reminder to log test failures (#2688)
  chore: Updates CHANGELOG.md for #2670
  feat: Supports `config_server_type` and `config_server_management_mode` in advanced_cluster (#2670)
  chore: Creates `advancedclustertpf` package for new implementation (#2679)
  chore: Removes deprecation warnings for `labels` in cluster/adv_cluster (#2678)
  doc: Adjusts `redact_client_log_data` doc (#2676)
  chore: Adds sleep in tests to avoid out of capacity errors (#2674)
  refactor: Adjust type of set structure in team update logic (#2675)
  chore: Updates CHANGELOG.md header for v1.21.1 release
  chore: Updates examples link in index.md for v1.21.1 release
  build(deps): bump go.mongodb.org/atlas-sdk (#2672)
  doc: Fixes Public -> Private Preview and adds contact link. (#2671)
  chore: Updates CHANGELOG.md for #2669
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maastha maastha maastha approved these changes

@oarbusi oarbusi oarbusi approved these changes

@marcosuma marcosuma marcosuma approved these changes

@EspenAlbert EspenAlbert EspenAlbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AgustinBettati @lantoli @EspenAlbert @marcosuma @oarbusi @maastha