Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Fixes Public -> Private Preview and adds contact link. #2671

Merged
merged 2 commits into from
Oct 9, 2024
Merged

doc: Fixes Public -> Private Preview and adds contact link. #2671

merged 2 commits into from
Oct 9, 2024

Conversation

EspenAlbert
Copy link
Collaborator

Description

Fixes Public -> Private Preview and adds contact link.

Link to any related issue(s): CLOUDP-277628

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@EspenAlbert EspenAlbert marked this pull request as ready for review October 9, 2024 13:37
@EspenAlbert EspenAlbert requested review from a team as code owners October 9, 2024 13:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

APIx bot: a message has been sent to Docs Slack channel

kyuan-mongodb
kyuan-mongodb approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@kyuan-mongodb kyuan-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Zuhairahmed
Zuhairahmed reviewed Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have since moved away from using "beta". feel free to merge after updating.

docs/data-sources/resource_policies.md Outdated Show resolved Hide resolved
docs/data-sources/resource_policy.md Outdated Show resolved Hide resolved
docs/resources/resource_policy.md Outdated Show resolved Hide resolved
examples/mongodbatlas_resource_policy/README.md Outdated Show resolved Hide resolved
templates/data-sources/resource_policies.md.tmpl Outdated Show resolved Hide resolved
templates/data-sources/resource_policy.md.tmpl Outdated Show resolved Hide resolved
templates/resources/resource_policy.md.tmpl Outdated Show resolved Hide resolved
AgustinBettati
AgustinBettati approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@AgustinBettati AgustinBettati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EspenAlbert EspenAlbert merged commit 23afbc2 into master Oct 9, 2024
36 checks passed
@EspenAlbert EspenAlbert deleted the CLOUDP-277628_rp_private_preview branch October 9, 2024 15:52
lantoli added a commit that referenced this pull request Oct 16, 2024
@lantoli
Merge branch 'master' into moved_old_tf_version
836882a 
* master: (44 commits)
  Remove RemoveResource from Create and Update (#2694)
  sleep first time only (#2696)
  fix: Ensures event_trigger `disabled` is included in the PUT payload (#2690)
  chore: Bump srvaroa/labeler from 1.11.0 to 1.11.1 (#2695)
  build(deps): bump go.mongodb.org/atlas-sdk (#2686)
  fix: Avoids setting organization id to empty when the USER_IS_NOT_FOUND (#2684)
  doc: Corrects default value of `auto_scaling_disk_gb_enabled` (#2683)
  chore: Reminder to log test failures (#2688)
  chore: Updates CHANGELOG.md for #2670
  feat: Supports `config_server_type` and `config_server_management_mode` in advanced_cluster (#2670)
  chore: Creates `advancedclustertpf` package for new implementation (#2679)
  chore: Removes deprecation warnings for `labels` in cluster/adv_cluster (#2678)
  doc: Adjusts `redact_client_log_data` doc (#2676)
  chore: Adds sleep in tests to avoid out of capacity errors (#2674)
  refactor: Adjust type of set structure in team update logic (#2675)
  chore: Updates CHANGELOG.md header for v1.21.1 release
  chore: Updates examples link in index.md for v1.21.1 release
  build(deps): bump go.mongodb.org/atlas-sdk (#2672)
  doc: Fixes Public -> Private Preview and adds contact link. (#2671)
  chore: Updates CHANGELOG.md for #2669
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zuhairahmed Zuhairahmed Zuhairahmed left review comments

@kyuan-mongodb kyuan-mongodb kyuan-mongodb approved these changes

@AgustinBettati AgustinBettati AgustinBettati approved these changes

@marcosuma marcosuma marcosuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@EspenAlbert @marcosuma @AgustinBettati @Zuhairahmed @kyuan-mongodb