chore: Adds sleep in tests to avoid out of capacity errors #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
commented
Oct 10, 2024
| @@ -48,8 +48,6 @@ func ProjectIDExecution(tb testing.TB) string { | |||
| sharedInfo.projectName = RandomProjectName() | |||
| tb.Logf("Creating execution project: %s\n", sharedInfo.projectName) | |||
| sharedInfo.projectID = createProject(tb, sharedInfo.projectName) | |||
| } else { | |||
lantoli
changed the title
lantoli
commented
Oct 10, 2024
| @@ -8,7 +8,7 @@ endif | |||
|
|
|||
| ACCTEST_REGEX_RUN?=^TestAcc | |||
| ACCTEST_TIMEOUT?=300m | |||
| PARALLEL_GO_TEST?=20 | |||
| PARALLEL_GO_TEST?=50 | |||
There was a problem hiding this comment.
don't limit parallel tests
EspenAlbert
reviewed
Oct 10, 2024
EspenAlbert
approved these changes
Oct 10, 2024
marcosuma
approved these changes
Oct 10, 2024
lantoli
added a commit
that referenced
this pull request
Oct 16, 2024
* master: (44 commits) Remove RemoveResource from Create and Update (#2694) sleep first time only (#2696) fix: Ensures event_trigger `disabled` is included in the PUT payload (#2690) chore: Bump srvaroa/labeler from 1.11.0 to 1.11.1 (#2695) build(deps): bump go.mongodb.org/atlas-sdk (#2686) fix: Avoids setting organization id to empty when the USER_IS_NOT_FOUND (#2684) doc: Corrects default value of `auto_scaling_disk_gb_enabled` (#2683) chore: Reminder to log test failures (#2688) chore: Updates CHANGELOG.md for #2670 feat: Supports `config_server_type` and `config_server_management_mode` in advanced_cluster (#2670) chore: Creates `advancedclustertpf` package for new implementation (#2679) chore: Removes deprecation warnings for `labels` in cluster/adv_cluster (#2678) doc: Adjusts `redact_client_log_data` doc (#2676) chore: Adds sleep in tests to avoid out of capacity errors (#2674) refactor: Adjust type of set structure in team update logic (#2675) chore: Updates CHANGELOG.md header for v1.21.1 release chore: Updates examples link in index.md for v1.21.1 release build(deps): bump go.mongodb.org/atlas-sdk (#2672) doc: Fixes Public -> Private Preview and adds contact link. (#2671) chore: Updates CHANGELOG.md for #2669 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds sleep in tests to avoid out of capacity errors.
This PR is to test the hypothesis that out of capacity errors in tests are caused because clusters are created simultaneously in the same project, see HELP-65223 for more info.
The previous PR didn't work because the way tests are executed in Go. They run in serial until
t.Parallel()is called. In that PR sleep was before that call so only test preparation was serialized but then all parallel tests would start at the same time.In this PR, the sleep is in PreCheck functions, that are called when the tests are already running in parallel.
Type of change:
Required Checklist:
Further comments