chore: Tries to reduce OUT_OF_CAPACITY during tests by moving cluster creation to other cloud providers #2206
Conversation
| Config: configDS(orgID, projectName, clusterName, name), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| checkExists(resourceName), | ||
| resource.TestCheckResourceAttrSet(resourceName, "project_id"), |
There was a problem hiding this comment.
this was supposed to be a DS test, but was checking the resource
There was a problem hiding this comment.
not the first time I found that
| @@ -142,3 +151,62 @@ func configBasic(orgID, projectName, clusterName, pipelineName string) string { | |||
| } | |||
| `, orgID, projectName, clusterName, pipelineName) | |||
| } | |||
|
|
|||
| func configBasicWithPluralDS(orgID, projectName, firstClusterName, secondClusterName, firstPipelineName, secondPipelineName string) string { | |||
There was a problem hiding this comment.
function name is misleading as it adds not only plural ds but a cluster resource and a singular ds.
can't it be the same configBasic function creating all resources needed?
There was a problem hiding this comment.
I'd avoid that because configBasic is also called for the migration test, and it wouldn't be basic anymore because it actually creates two clusters and two data lakes in order to test the plural part of it.
Would you suggest a different name perhaps?
There was a problem hiding this comment.
@lantoli I am going to go ahead with this so I can get unblocked (since it's public holiday for you). Sorry about that, we can always change it in a follow-up PR.
* master: chore: Minimise permissions when not needed. (#2220) chore: Bump github.com/aws/aws-sdk-go from 1.51.27 to 1.51.32 (#2225) chore: Bump crazy-max/ghaction-import-gpg from 2 to 6 (#2227) chore: Bump tj-actions/verify-changed-files (#2229) chore: Bump actions/checkout from 4.1.2 to 4.1.4 (#2228) chore: Bump peter-evans/create-pull-request from 6.0.4 to 6.0.5 (#2230) chore: Bump hashicorp/setup-terraform from 3.0.0 to 3.1.0 (#2231) chore: Tries to reduce OUT_OF_CAPACITY during tests by moving cluster creation to other cloud providers (#2206) fix: Fixes push-based log export migration tests (#2224) chore: Updates CHANGELOG.md for #2221
Description
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments