-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Tries to reduce OUT_OF_CAPACITY during tests by moving cluster creation to other cloud providers #2206
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
544ce08
chore: Moves cluster cloud provider to GCP for data lake pipeline tests.
marcosuma 476ae75
moves to azure, select UK_WEST and UK_SOUTH.
marcosuma c896a89
use UK_WEST only.
marcosuma 6f2a057
use US_EAST_2 only.
marcosuma dc70d5e
aggregates singular and plural data source.
marcosuma 3b82a6f
missing data source.
marcosuma 65fe91f
fixes bug.
marcosuma 5699f4f
aggregates plura DS test with resource one.
marcosuma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
93 changes: 0 additions & 93 deletions
93
internal/service/datalakepipeline/data_source_data_lake_pipeline_test.go
This file was deleted.
Oops, something went wrong.
139 changes: 0 additions & 139 deletions
139
internal/service/datalakepipeline/data_source_data_lake_pipelines_test.go
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
function name is misleading as it adds not only plural ds but a cluster resource and a singular ds.
can't it be the same configBasic function creating all resources needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd avoid that because configBasic is also called for the migration test, and it wouldn't be basic anymore because it actually creates two clusters and two data lakes in order to test the plural part of it.
Would you suggest a different name perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lantoli I am going to go ahead with this so I can get unblocked (since it's public holiday for you). Sorry about that, we can always change it in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, that's fine